Skip to content

fix: use snake_case for access_modes in pvc sample#516

Merged
ishaankalra merged 1 commit intomasterfrom
fix/pvc-access-modes-snake-case
Feb 24, 2026
Merged

fix: use snake_case for access_modes in pvc sample#516
ishaankalra merged 1 commit intomasterfrom
fix/pvc-access-modes-snake-case

Conversation

@anujhydrabadi
Copy link
Collaborator

@anujhydrabadi anujhydrabadi commented Feb 24, 2026

Summary

  • Fixed accessModes (camelCase) to access_modes (snake_case) in the pvc/k8s sample in facets.yaml
  • The Terraform code does lookup(local.advanced, "access_modes", ...), so the camelCase key was being ignored and the default was always used

Test plan

  • Verify that deploying a PVC with a custom access_modes value in advanced correctly applies the setting

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the PVC (Persistent Volume Claim) access modes configuration setting name from accessModes to access_modes for improved consistency.

The sample in facets.yaml used camelCase `accessModes` but the Terraform
code looks up `access_modes` (snake_case), so the sample key was ignored.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e162f06 and 57f00bf.

📒 Files selected for processing (1)
  • modules/pvc/k8s/0.1/facets.yaml

Walkthrough

A YAML property in the PVC facet configuration file was renamed from accessModes to access_modes in the advanced section, modifying the accepted field name in the public data schema.

Changes

Cohort / File(s) Summary
PVC Facet Schema
modules/pvc/k8s/0.1/facets.yaml
Renamed accessModes property to access_modes in the advanced section, updating the field name within the configuration schema while preserving existing values.
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description provides context and test plan but is missing several required template sections including Related issues, Type of change, Checklist items, and Reviewer instructions. Complete the pull request description template by filling out the missing sections: specify the related issue/task, select the type of change (Bug fix), complete the checklist, and add reviewer instructions if applicable.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: renaming a property from camelCase to snake_case in the PVC sample configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/pvc-access-modes-snake-case

Comment @coderabbitai help to get the list of available commands and usage tips.

@ishaankalra ishaankalra merged commit b002af7 into master Feb 24, 2026
2 checks passed
@ishaankalra ishaankalra deleted the fix/pvc-access-modes-snake-case branch February 24, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants