fix: use snake_case for access_modes in pvc sample#516
Merged
ishaankalra merged 1 commit intomasterfrom Feb 24, 2026
Merged
Conversation
The sample in facets.yaml used camelCase `accessModes` but the Terraform code looks up `access_modes` (snake_case), so the sample key was ignored. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
WalkthroughA YAML property in the PVC facet configuration file was renamed from Changes
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
rauneetverma
approved these changes
Feb 24, 2026
ishaankalra
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accessModes(camelCase) toaccess_modes(snake_case) in the pvc/k8s sample infacets.yamllookup(local.advanced, "access_modes", ...), so the camelCase key was being ignored and the default was always usedTest plan
access_modesvalue inadvancedcorrectly applies the setting🤖 Generated with Claude Code
Summary by CodeRabbit
accessModestoaccess_modesfor improved consistency.