Skip to content

feat: port custom hooks to NGF 2.4.1 chart#517

Open
unni-facets wants to merge 1 commit intodevelopfrom
feat/ngf-241-chart-hooks
Open

feat: port custom hooks to NGF 2.4.1 chart#517
unni-facets wants to merge 1 commit intodevelopfrom
feat/ngf-241-chart-hooks

Conversation

@unni-facets
Copy link
Contributor

Summary

  • Port custom hooks (wait-for-lb, cleanup) and certs-job annotation fixes from the 2.3.0 chart into the 2.4.1 nginx-gateway-fabric Helm chart
  • Add waitForLoadBalancer values to prevent Route53 ARRDATAIllegalIPv4Address errors on first deploy
  • Update facets.yaml, main.tf, and outputs.tf for the nginx_gateway_fabric_legacy module

Test plan

  • Deploy to a test environment and verify the LB wait hook runs before Route53 registration
  • Verify cleanup hook fires on uninstall
  • Confirm certs-job completes without annotation errors

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 25, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • facets-saas

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/ngf-241-chart-hooks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@unni-facets unni-facets force-pushed the feat/ngf-241-chart-hooks branch 3 times, most recently from 50673b8 to 5db4e67 Compare February 25, 2026 07:20
Add wait-for-lb-hook.yaml, cleanup-hook.yaml, fix certs-job.yaml
hook annotations, and add waitForLoadBalancer values to the 2.4.1
Helm chart. The LB wait hook prevents Route53 ARRDATAIllegalIPv4Address
errors on first deploy.
@unni-facets unni-facets force-pushed the feat/ngf-241-chart-hooks branch from 5db4e67 to 418716f Compare February 25, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant