feat: port custom hooks to NGF 2.4.1 chart#517
Open
unni-facets wants to merge 1 commit intodevelopfrom
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
50673b8 to
5db4e67
Compare
Add wait-for-lb-hook.yaml, cleanup-hook.yaml, fix certs-job.yaml hook annotations, and add waitForLoadBalancer values to the 2.4.1 Helm chart. The LB wait hook prevents Route53 ARRDATAIllegalIPv4Address errors on first deploy.
5db4e67 to
418716f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitForLoadBalancervalues to prevent Route53ARRDATAIllegalIPv4Addresserrors on first deployfacets.yaml,main.tf, andoutputs.tffor the nginx_gateway_fabric_legacy moduleTest plan