Drop support for EOL python 3.6, add support for python 3.10 and django 4.0#904
Merged
Merged
Conversation
Member
|
Can also update the tags in |
Contributor
Author
|
@francoisfreitag done! |
Member
francoisfreitag
left a comment
francoisfreitag
left a comment
There was a problem hiding this comment.
Can also drop Django 3.1. That will simplify the test matrix.
francoisfreitag
approved these changes
Feb 15, 2022
Member
francoisfreitag
left a comment
francoisfreitag
left a comment
There was a problem hiding this comment.
Looking good, thanks! 🎉
Can you squash the commits please?
last-partizan
force-pushed
the
drop-3.6
branch
from
076ada6 to
4268d82
Compare
Contributor
Author
|
Ready! |
Member
There was a problem hiding this comment.
We missed another case, the readme mentions:
# run tests inside a specific environment
$ tox -e py36-django20-alchemy13-mongoengine017
These environments are dead. Perhaps use djangomain and py310?
https://github.com/FactoryBoy/factory_boy#contributing
last-partizan
force-pushed
the
drop-3.6
branch
from
4268d82 to
6ac13be
Compare
Contributor
Author
|
Sure, fixed! |
Member
|
Sweet, thanks! ⭐ |
Contributor
|
The badges on README.md say that Python 3.6 is still supported and 3.10 is not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my other PR (#903) i would like to add some basic typing support for factory-boy, but it uses features unavailable for python 3.6, and i haven't found simple workarounds.
Python 3.6 has reached end of life, so maybe drop it, and add 3.10?
This also changes pypy, from just
pypy3, which resolves as pypy-3.6, topypy-3.7andpypy-3.8.Quotes used for versions, becouse without them you cannot write
3.10, yaml parses it as number 3.1.