fix(signature): ag2#1
Open
oscar-wos wants to merge 1 commit intoFallen-Networks:mainfrom
Open
Conversation
oscar-wos
changed the title
There was a problem hiding this comment.
Pull request overview
Updates the MovementUnlocker gamedata to match an upstream binary change so the plugin can continue to apply its patch after a game update.
Changes:
- Updated Windows and Linux signature patterns for
MovementUnlocker. - Updated the Windows patch bytes (relative jump displacement) for
MovementUnlocker. - Bumped plugin metadata version to
1.0.1.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/resources/gamedata/signatures.jsonc | Updates the pattern(s) used to locate the patch site in server binaries. |
| src/resources/gamedata/patches.jsonc | Adjusts the Windows patch bytes applied at the matched location. |
| src/FallenMovementUnlocker.cs | Bumps plugin metadata version while continuing to apply the same patch name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| namespace FallenMovementUnlocker; | ||
|
|
||
| [PluginMetadata(Id = "FallenMovementUnlocker", Version = "1.0.0", Name = "FallenMovementUnlocker", Author = "Source2ZE, ported by Slime to SwiftlyS2")] | ||
| [PluginMetadata(Id = "FallenMovementUnlocker", Version = "1.0.1", Name = "FallenMovementUnlocker", Author = "Source2ZE, ported by Slime to SwiftlyS2")] |
There was a problem hiding this comment.
PluginMetadata version was bumped to 1.0.1, but the project’s AssemblyVersion (src/FallenMovementUnlocker.csproj) and version.txt are still 1.0.0. If releases/packaging rely on those values, this mismatch can cause confusing version reporting; consider updating them in sync (or document why they intentionally differ).
Suggested change
| [PluginMetadata(Id = "FallenMovementUnlocker", Version = "1.0.1", Name = "FallenMovementUnlocker", Author = "Source2ZE, ported by Slime to SwiftlyS2")] | |
| [PluginMetadata(Id = "FallenMovementUnlocker", Version = "1.0.0", Name = "FallenMovementUnlocker", Author = "Source2ZE, ported by Slime to SwiftlyS2")] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source2ZE/CS2Fixes@6c215c5