Make the MishapInvalidIota lang fallback actually work #994
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
object-Object
approved these changes
Jan 17, 2026
Member
object-Object
left a comment
object-Object
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding the comments as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exactly what it says in the title. Turns out
Component.translatableWithFallBack()doesn't translate the fallback string and just uses it as a literal, so the current implementation of MishapInvalidIota doesn't properly fall back to the existinginvalid_valuekey if the newdesckey doesn't exist. This PR fixes that, and also adds some comments explaining why two different keys are being checked in the first place.