Skip to content

Document UTF-8 wrapper coverage against LuaJIT Windows import surface#1

Draft
Copilot wants to merge 76 commits intomasterfrom
copilot/analyze-source-improvements
Draft

Document UTF-8 wrapper coverage against LuaJIT Windows import surface#1
Copilot wants to merge 76 commits intomasterfrom
copilot/analyze-source-improvements

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 22, 2026

This PR addresses the request to verify whether additional patching is needed based on the current LuaJIT Windows import list.
Result: path/command/environment-sensitive imports are already covered by existing UTF-8 wrappers; no new wrapper hooks were introduced.

  • What was reviewed

    • Compared the provided import list with the current wrapper layer (utf8_wrappers.c/.h).
    • Focused on APIs that consume ANSI path/command/env strings and can break with non-ASCII input.
  • Coverage confirmed

    • Already wrapped and redirected:
      • fopen / freopen
      • remove
      • rename
      • _popen
      • system
      • getenv
      • GetModuleFileNameA
      • LoadLibraryExA
  • What changed in this PR

    • Added an explicit Imported-symbol audit (Windows) section to README.md.
    • Documented why the remaining imported symbols do not need Unicode-path wrappers (math/runtime/threading/memory/descriptor-level APIs).
// Existing redirections already in place
#define fopen               fopen_utf8
#define remove              remove_utf8
#define rename              rename_utf8
#define _popen              popen_utf8
#define system              system_utf8
#define getenv              getenv_utf8
#define GetModuleFileNameA  GetModuleFileNameA_utf8
#define LoadLibraryExA      LoadLibraryExA_utf8

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI and others added 6 commits February 22, 2026 14:13
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Copilot AI changed the title [WIP] Analyze source code and suggest possible improvements Automate LuaJIT Unicode patch integration for MinGW/MSVC without upstream source edits Feb 22, 2026
Copilot AI requested a review from johnd0e February 22, 2026 14:17
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Copilot AI changed the title Automate LuaJIT Unicode patch integration for MinGW/MSVC without upstream source edits Document per-target MinGW/MSVC build commands in README Feb 22, 2026
Copilot AI and others added 6 commits February 22, 2026 14:29
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Copilot AI changed the title Document per-target MinGW/MSVC build commands in README Add Windows CI + release automation for patched LuaJIT and UTF-8 wrapper verification Feb 22, 2026
Copilot stopped work on behalf of johnd0e due to an error February 22, 2026 18:51
Copilot AI and others added 2 commits February 22, 2026 19:26
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Copilot AI and others added 2 commits February 23, 2026 01:54
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Copilot AI changed the title Fix CI regressions in Windows builds: correct MinGW arm64 targeting, re-enable MSVC arm64 tests, and restore Unicode fixture setup Stabilize Windows CI Unicode coverage: MinGW test execution path, unified fixture naming, and ARM64 test policy Feb 23, 2026
Copilot AI and others added 2 commits February 23, 2026 02:12
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Copilot AI changed the title Stabilize Windows CI Unicode coverage: MinGW test execution path, unified fixture naming, and ARM64 test policy Stabilize Windows CI for LuaJIT Unicode: fix MinGW ARM64 build flags, align MinGW runtime test env, and revert fixture setup to pure batch Feb 23, 2026
Copilot AI and others added 3 commits February 23, 2026 02:24
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Copilot AI changed the title Stabilize Windows CI for LuaJIT Unicode: fix MinGW ARM64 build flags, align MinGW runtime test env, and revert fixture setup to pure batch Stabilize CI by disabling broken MinGW ARM64 lane and fixing Unicode fixture generation for test reliability Feb 23, 2026
Copilot AI and others added 7 commits February 23, 2026 16:41
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
…code match path

Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Copilot AI changed the title Stabilize CI by disabling broken MinGW ARM64 lane and fixing Unicode fixture generation for test reliability Stabilize CI by removing failing MinGW ARM64 lane and hardening Unicode fixture-driven tests Feb 23, 2026
Co-authored-by: johnd0e <1838643+johnd0e@users.noreply.github.com>
Copilot AI changed the title Stabilize CI by removing failing MinGW ARM64 lane and hardening Unicode fixture-driven tests Document UTF-8 wrapper coverage against LuaJIT Windows import surface Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants