test(decomposed-server): fix np.float32 vs python-float equality flake#142
Merged
Merged
Conversation
call["state"][0, 0] is np.float32 (per the dtype assertion three lines above + the upstream marshal layer's float32 cast). Comparing np.float32(0.1) to Python's 0.1 (float64) under == is False — the bit patterns differ at boundary precision. Use np.isclose. Flake started surfacing on main when commit f9811d2 pinned numpy<2 (numpy 2.x had different repr rules that masked the issue). Affects pi05_decomposed test only; no production impact. Per CLAUDE.md "fix it now, not later" — this was noted as a follow-up during PR #137/#138 merges + earlier on the fluxvla docs alignment session; landing the fix as part of the lift #4 PR cleans the CI signal. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the pre-existing test flake on main that has been blocking pytest CI since commit f9811d2 pinned numpy<2.
call["state"][0, 0]is np.float32; comparing to Python's 0.1 (float64) under==is False due to precision boundary. Usenp.isclose.Unblocks PRs #139, #140, #141 from this same flake.
🤖 Generated with Claude Code