Add support for private messages #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add messages collection - Add threads collection
Member
Author
|
@joshmorel I don't know Luis' or Kevin's username here, so please add then as reviewers also 😅 |
|
@Naraujo13 I think you've done a great job. The only thing I'd change is the location, as @joshmorel said. Don't know if you'd like to add something about that?! |
Member
Author
As mentioned in the model PR, I agree about removing the location ref. I'm also questioning the need for an embedded ref for the author at all in the |
- Replace embedded author doc for simple reference in messages to optimize space (it will always be used with the thread, that already has that embedding) - Remove location from the author doc in the threads collection - Update relationships names in documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request aim to achieve? 💯
Adds support to private messages
What this PR does?
threadsto store conversationsmessagesto store the conversation's messagesFeature
Desktop
Mobile
Collections
The following collections were modified:
Threads
Messages