feat: add curio debug level logging, capture stderr in container logs#80
Merged
redpanda-f merged 3 commits intomainfrom Mar 10, 2026
Merged
feat: add curio debug level logging, capture stderr in container logs#80redpanda-f merged 3 commits intomainfrom
redpanda-f merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds more verbose Curio (PDP) logging and improves Docker log capture so troubleshooting output isn’t missed.
Changes:
- Inject
GOLOG_LOG_LEVEL=pdp=debuginto Curio containers (daemon + DB setup helper containers). - Update Docker container log collection to include both stdout and stderr.
- Centralize Curio log level configuration in
src/constants.rs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/docker/core.rs |
Adjusts container log retrieval to include stderr (but changes error-handling semantics). |
src/constants.rs |
Introduces a constant for Curio’s GOLOG log-level setting. |
src/commands/start/curio/db_setup.rs |
Adds the Curio log-level env var to the DB setup/migration containers. |
src/commands/start/curio/daemon.rs |
Adds the Curio log-level env var to the Curio daemon container create args. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
4 tasks
rvagg
added a commit
to filecoin-project/curio
that referenced
this pull request
Mar 10, 2026
go-log doesn't have hierarchical selection so pdp/add etc don't help us and we also have pdp-contracts as an inconsistent namespace. So consolidate them all into "pdp" for easier selection. Ref: FilOzone/foc-devnet#80
rvagg
added a commit
to filecoin-project/curio
that referenced
this pull request
Mar 10, 2026
go-log doesn't have hierarchical selection so pdp/add etc don't help us and we also have pdp-contracts as an inconsistent namespace. So consolidate them all into "pdp" for easier selection. Ref: FilOzone/foc-devnet#80
rvagg
approved these changes
Mar 10, 2026
Contributor
rvagg
left a comment
There was a problem hiding this comment.
Note we don't capture all the logs with this, but filecoin-project/curio#1081 should help us out when we update to that.
rvagg
added a commit
to filecoin-project/curio
that referenced
this pull request
Mar 10, 2026
go-log doesn't have hierarchical selection so pdp/add etc don't help us and we also have pdp-contracts as an inconsistent namespace. So consolidate them all into "pdp" for easier selection. Ref: FilOzone/foc-devnet#80
rvagg
added a commit
to filecoin-project/curio
that referenced
this pull request
Mar 11, 2026
pdp logger for the shared components pdpv0 logger for pdpv0 specific components Ref: FilOzone/foc-devnet#80
LexLuthr
pushed a commit
to filecoin-project/curio
that referenced
this pull request
Mar 12, 2026
pdp logger for the shared components pdpv0 logger for pdpv0 specific components Ref: FilOzone/foc-devnet#80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split PR of #62