Skip to content

feat: add curio debug level logging, capture stderr in container logs#80

Merged
redpanda-f merged 3 commits intomainfrom
feat/redpanda/curio-debug-logging
Mar 10, 2026
Merged

feat: add curio debug level logging, capture stderr in container logs#80
redpanda-f merged 3 commits intomainfrom
feat/redpanda/curio-debug-logging

Conversation

@redpanda-f
Copy link
Copy Markdown
Contributor

Split PR of #62

@redpanda-f redpanda-f self-assigned this Mar 9, 2026
@redpanda-f redpanda-f requested review from Copilot and rvagg March 9, 2026 09:02
@FilOzzy FilOzzy added this to FOC Mar 9, 2026
@github-project-automation github-project-automation bot moved this to 📌 Triage in FOC Mar 9, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds more verbose Curio (PDP) logging and improves Docker log capture so troubleshooting output isn’t missed.

Changes:

  • Inject GOLOG_LOG_LEVEL=pdp=debug into Curio containers (daemon + DB setup helper containers).
  • Update Docker container log collection to include both stdout and stderr.
  • Centralize Curio log level configuration in src/constants.rs.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/docker/core.rs Adjusts container log retrieval to include stderr (but changes error-handling semantics).
src/constants.rs Introduces a constant for Curio’s GOLOG log-level setting.
src/commands/start/curio/db_setup.rs Adds the Curio log-level env var to the DB setup/migration containers.
src/commands/start/curio/daemon.rs Adds the Curio log-level env var to the Curio daemon container create args.

redpanda-f and others added 2 commits March 9, 2026 17:36
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rvagg added a commit to filecoin-project/curio that referenced this pull request Mar 10, 2026
go-log doesn't have hierarchical selection so pdp/add etc don't help us
and we also have pdp-contracts as an inconsistent namespace. So consolidate
them all into "pdp" for easier selection.

Ref: FilOzone/foc-devnet#80
rvagg added a commit to filecoin-project/curio that referenced this pull request Mar 10, 2026
go-log doesn't have hierarchical selection so pdp/add etc don't help us
and we also have pdp-contracts as an inconsistent namespace. So consolidate
them all into "pdp" for easier selection.

Ref: FilOzone/foc-devnet#80
Copy link
Copy Markdown
Contributor

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note we don't capture all the logs with this, but filecoin-project/curio#1081 should help us out when we update to that.

@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FOC Mar 10, 2026
@redpanda-f redpanda-f merged commit 0f94321 into main Mar 10, 2026
2 checks passed
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Mar 10, 2026
@redpanda-f redpanda-f deleted the feat/redpanda/curio-debug-logging branch March 10, 2026 03:53
rvagg added a commit to filecoin-project/curio that referenced this pull request Mar 10, 2026
go-log doesn't have hierarchical selection so pdp/add etc don't help us
and we also have pdp-contracts as an inconsistent namespace. So consolidate
them all into "pdp" for easier selection.

Ref: FilOzone/foc-devnet#80
rvagg added a commit to filecoin-project/curio that referenced this pull request Mar 11, 2026
pdp logger for the shared components
pdpv0 logger for pdpv0 specific components

Ref: FilOzone/foc-devnet#80
LexLuthr pushed a commit to filecoin-project/curio that referenced this pull request Mar 12, 2026
pdp logger for the shared components
pdpv0 logger for pdpv0 specific components

Ref: FilOzone/foc-devnet#80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

4 participants