feat: use PDPVerifier.findPieceIdsByCid for efficient CID→ID lookups#718
Open
Chaitu-Tatipamula wants to merge 2 commits intoFilOzone:masterfrom
Open
feat: use PDPVerifier.findPieceIdsByCid for efficient CID→ID lookups#718Chaitu-Tatipamula wants to merge 2 commits intoFilOzone:masterfrom
Chaitu-Tatipamula wants to merge 2 commits intoFilOzone:masterfrom
Conversation
Chaitu-Tatipamula
force-pushed
the
find-piece-ids-by-cid
branch
from
90b36bf to
c48c67e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #667
Summary
Replaces expensive full-piece-list fetches with the new
PDPVerifier.findPieceIdsByCidcontract method for direct CID→ID lookups.Changes
synapse-core
findPieceIdsByCid+findPieceIdsByCidCallinpdp-verifier/findPieceIdsByCidhandler and default presetsynapse-sdk
pieceStatus(): ReplacedgetActivePieces()+.find()with singlefindPieceIdsByCid()call_getPieceIdByCID(): Replaced SP APIgetDataSet()+.find()withfindPieceIdsByCid()callTests
findPieceIdsByCidcall builder and mocked RPCpieceStatustest for "piece not found" scenarioWhy
Previously
pieceStatus()fetched all active pieces then searched linearly — O(n) and potentially fails on large datasets. Now it's a single targeted contract call.