Add convenience comparison operators for DeviceScreenType and RefinedSize#55
Open
tjarvstrand wants to merge 1 commit intoFilledStacks:masterfrom
Open
Conversation
|
@FilledStacks +1. It would also be nice if sometime soon we can get rid of the deprecated fields. It makes working with switch expressions annoying. |
Contributor
Author
|
@mcmah309 Sadly, this repo seems pretty dead. |
Owner
|
It's not 😅 we just don't have new features we need to add. But we use it in all our projects. I'll review this and merge in. I maintain 11 open source packages so excuse my tardiness on some of them, I get a lot of requests, I do this alone, I fund it entirely myself from my business profits and I don't ask for any sponsorship or that anyone use it. |
FilledStacks
requested changes
Jun 25, 2024
Owner
FilledStacks
left a comment
FilledStacks
left a comment
There was a problem hiding this comment.
I like this addition.
Can you please update the version to 0.8.0 and add an entry into the change log
|
|
||
| final int _ordinal; | ||
|
|
||
| bool operator >(DeviceScreenType other) => _ordinal > other._ordinal; |
tjarvstrand
force-pushed
the
add-convenience-comparison-operators
branch
from
e9667c2 to
f7a4745
Compare
Contributor
Author
|
Done! |
tjarvstrand
force-pushed
the
add-convenience-comparison-operators
branch
from
f7a4745 to
c9b2937
Compare
Contributor
Author
|
@FilledStacks Can this be merged now? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.