Skip to content

Add Next features#10

Merged
morganchen12 merged 8 commits into
mainfrom
mc/next
May 6, 2026
Merged

Add Next features#10
morganchen12 merged 8 commits into
mainfrom
mc/next

Conversation

@morganchen12
Copy link
Copy Markdown
Collaborator

No description provided.

@morganchen12 morganchen12 requested a review from jhuleatt April 21, 2026 21:45
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors recipe data management by migrating from denormalized fields to Firestore pipelines for real-time calculation of ratings and likes. It renames the 'saves' feature to 'likes' throughout the application, updates the Firebase SDK to version 12.12.0, and implements AI-powered search with scoring. UI enhancements include the addition of recipe image displays and various linting and type improvements. A review comment points out that the likedOnly filter logic, which currently checks for any recipe with more than zero likes, may be semantically confusing if the intended behavior was to display a user's personal likes, suggesting either a rename or a logic adjustment.

Comment thread app/firebase/data.ts Outdated
@morganchen12
Copy link
Copy Markdown
Collaborator Author

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Firebase dependency to version 12.12.0 and migrates the 'saves' functionality to a 'likes' system powered by Firestore pipelines for real-time aggregation. It refactors data fetching to calculate average ratings and like counts on-the-fly, removes manual aggregation logic, and updates Firestore security rules accordingly. UI enhancements include image previews in the recipe list and new filtering options. Feedback points out a potential crash for unauthenticated users in the recipes route and suggests more robust handling of the liked-only filter in the data layer.

Comment thread app/routes/recipes.tsx
Comment thread app/firebase/data.ts
Copy link
Copy Markdown

@jhuleatt jhuleatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! The eslint-disable everywhere makes me nervous, everything else is mostly nits

Comment thread app/firebase/data.ts
Comment thread app/routes/chat.tsx
Comment thread app/routes/chat.tsx
Comment thread app/routes/generate.tsx
Comment thread app/routes/generate.tsx
Comment thread app/routes/home.tsx
Comment thread app/routes/home.tsx
Comment thread app/routes/recipes.tsx Outdated
@morganchen12 morganchen12 merged commit 5198b05 into main May 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants