Skip to content

Conversation

@Niduroki
Copy link

Upstream has changed to using PDO escape, which we don't use, thus I have implemented a "dirty" addslashes escape within a custom class, which should work fine 🤞

Feel free to do some own testing.

Also I have updated get_results to fetchObjects. There does not seem to be any difference in functionality, just that get_results has been renamed.

Chris added 2 commits March 25, 2023 12:15
Upstream has changed to using PDO escape, which we don't use, thus I
have implemented a "dirty" addslashes escape, which works fine.
Better than my dirty addslashes escaping
@Niduroki
Copy link
Author

Nevermind the dirty-escape.
Copying the actual escape (using PDO::quote()) from the parent YDB object works fine, too.

My PHP is a bit rusty, and the way yourls deals with custom db-drivers seems somewhat weird, thus there most certainly is a better way of dealing with this, but it works and seems understandable enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant