fix: added dummy AllOutput to old API #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Apologies for the spam here with testing, windows compiling is my nemesis. In order to keep compilers happy, I renamed the AllOutput function to WriteOutputs. This matches what is in the MD-F code, and IMO is more clear about what is happening. |
Collaborator
You can use MoorDyn_Log |
Collaborator
Author
|
@sanguinariojoe just made that change, this should be good to go now |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dummy AllOutput function to the old API wrapper that prints a message stating "In version 2, AllOutput is automatically called by MoorDynStep". This reduces warning messages when using the old API. This was seen when updating the WECSim libraries in WEC-Sim/MoorDyn#7.
@sanguinariojoe, let me know if there is a better way to print the message here. I didn't see anything in the C header files that allowed for the use of LOGMSG.