Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a comprehensive logging system and main menu UI for the Echoform MMO game. The changes replace GD.Print statements with a centralized EchoformLogger, implement UI elements for connecting to the authoritative server, add a cinematic camera system, and include scene/asset updates.
Key changes:
- Centralized logging system with configurable log levels (DEBUG, INFO, WARN, ERROR)
- New main menu with connection status display replacing the old connecting menu
- Cinematic camera controller for intro sequences with player control disabling
- Extensive intro scene animation with tree growth and player spawn sequences
Reviewed Changes
Copilot reviewed 37 out of 55 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| game/scripts/util/LogLevel.cs | Defines enum for log levels (DEBUG, INFO, WARN, ERROR) |
| game/scripts/util/EchoformLogger.cs | Implements centralized logger with stack trace and colored console output |
| game/scripts/menus/mainmenu.gd | New main menu script handling connection state UI |
| game/scripts/entity/player/Player.cs | Adds ControlEnabled flag for disabling player input |
| game/scripts/entity/player/CinematicPlayerCamera.cs | Camera controller for cutscenes with anchoring and tweening support |
| game/scripts/authoritative/protocol/*.cs | Replaces GD.Print with EchoformLogger calls throughout |
| game/scripts/authoritative/AuthoritativeServerConnection.cs | Refactors logging, adds Connected signal, extracts error modal display |
| game/scenes/title_screen/main_menu.tscn | New main menu scene with connecting label and action buttons |
| game/scenes/intro.tscn | Extensive intro scene with animation timeline |
| game/project.godot | Registers EchoformLogger autoload and updates main scene path |
Comments suppressed due to low confidence (1)
game/scripts/util/EchoformLogger.cs:13
- Write to static field from instance method, property, or constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.