Skip to content

Do not remove output dir #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bonajo merged 3 commits into from
Mar 6, 2026
Merged

Do not remove output dir #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52415cd
fix: remove output directory cleanup before file processing
Bonajo Mar 6, 2026
4812b8a
build: update version to 1.2.0 and regenerate poetry.lock
Bonajo Mar 6, 2026
f343d6b
fix: remove test for output directory cleanup
Bonajo Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions codestripper/code_stripper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ def strip_files(files: Iterable[str], working_directory: Union[str, None] = None

cwd = get_working_directory(working_directory)
out = os.path.join(os.getcwd(), output)
if os.path.isdir(out):
shutil.rmtree(out)

stripped_files: List[str] = []
has_errors: bool = False
for file in files:
Expand Down
21 changes: 18 additions & 3 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "codestripper"
version = "1.1.2"
version = "1.2.0"
description = "CodeStripper used to strip code from assignments"
authors = ["Bonajo <m.bonajo@fontys.nl>"]
maintainers = ["Bonajo <m.bonajo@fontys.nl>"]
Expand Down
9 changes: 0 additions & 9 deletions tests/test_codestripper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,6 @@ def test_log_invalid_tag(monkeypatch: pytest.MonkeyPatch, caplog: LogCaptureFixt
assert len(errors) == 1 and "InvalidTag.java" in errors[0] and "2" in errors[0]


def test_project_out_removes(monkeypatch: pytest.MonkeyPatch):
monkeypatch.chdir(test_project_dir)
files = FileUtils(["**/*.java", "pom.xml"], working_directory="testproject").get_matching_files()
strip_files(files, "testproject", output="out")
files = FileUtils(["pom.xml"], working_directory="testproject").get_matching_files()
strip_files(files, "testproject", output="out")
assert not os.path.isdir(Path("out/src"))


def test_fail_on_error(monkeypatch: pytest.MonkeyPatch, caplog: pytest.LogCaptureFixture):
monkeypatch.chdir(test_project_dir)
files = FileUtils(["**/*.java"], working_directory="files").get_matching_files()
Expand Down