fix(workflow-executor): pass collectionId to MCP activity log#1608
Merged
Scra3 merged 2 commits intoMay 28, 2026
Merged
Conversation
The MCP step executor was missing collectionId in buildActivityLogArgs, causing activity logs to not show up in the Forest Admin UI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ionId Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
hercemer42
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collectionIdinbuildActivityLogArgsRoot cause
McpStepExecutor.buildActivityLogArgsreturnedrenderingId,action,type, andlabelbut omittedcollectionId, which is present in all other step executors (update-record,trigger-record-action,load-related-record).fixes PRD-414
🤖 Generated with Claude Code
Note
Pass
collectionIdto MCP activity log inMcpStepExecutor.buildActivityLogArgsAdds
collectionIdfromthis.contextto theCreateActivityLogArgsreturned bybuildActivityLogArgsin mcp-step-executor.ts. A new test in mcp-step-executor.test.ts verifies thatactivityLogPort.createPendingreceivescollectionIdwhen executing a fully automated MCP step.Macroscope summarized 7dacdac.