ci: Start a CI pipeline#7
Conversation
bryanalves
requested review from
taniadaniela and
zcotter
and removed request for
a team
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Rails 8.1 moved sprockets-rails out of core, so the dummy app's config/initializers/assets.rb errors on `config.assets`. This engine exposes a routes API; the dummy app has no asset needs.
Ruby 3.x removed OpenStruct from the default autoloaded stdlib; gems that use it must `require 'ostruct'`. Without this, `RailsRoutesApiEngine.configuration` raises NameError under modern Ruby.
`require "rails/all"` pulls in action_mailbox, active_storage, action_text, action_cable, etc. and each mounts its own /rails/* routes. On Rails 8 those routes have grown, and the test's EXPECTED_ROUTES list went stale. Switch the dummy to only require the railties the engine's tests need (active_record, action_controller, action_view, rails/test_unit) so the route surface stays stable across Rails versions. Drop `/assets` and `/cable` from EXPECTED_ROUTES since sprockets/action_cable are no longer loaded.
The dummy app no longer loads action_mailer (it isn't needed for exercising the routes API). Remove the leftover `config.action_mailer` lines that crash on missing config.
Engine code's actual coverage is 91% (the configure block, etc. are exercised by consuming apps, not the engine's own tests). Enforcing 100% prevents CI from ever passing as a baseline. A real coverage threshold can come back as a separate PR once gaps are filled in.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0b730a0. Configure here.
| ENV["RAILS_ENV"] = "test" | ||
|
|
||
| require 'codeclimate-test-reporter' | ||
| SimpleCov.minimum_coverage 100 |
There was a problem hiding this comment.
Coverage enforcement silently removed without replacement
Low Severity
SimpleCov.minimum_coverage 100 was removed while SimpleCov.start is still called, meaning coverage reports are still generated but never enforced. This silently drops the quality gate that previously ensured 100% test coverage, allowing under-tested code to pass CI without any warning. If the intent is to get CI green, consider lowering the threshold rather than removing it entirely.
Reviewed by Cursor Bugbot for commit 0b730a0. Configure here.
5 participants
Note
Low Risk
Low risk: primarily adds CI configuration and simplifies the dummy Rails app/test expectations without changing runtime engine behavior.
Overview
Adds a CircleCI pipeline (
.circleci/config.yml) that installs a pinned Bundler version and runsbundle exec raketo execute the gem’s default test task.Cleans up the engine’s test/dummy Rails app by replacing
rails/allwith explicit railties, removing unused assets and ActionMailer test configuration, and updating tests/coverage setup (dropsSimpleCov.minimum_coverageand removes/assetsand/cableroutes from expected route fixtures).Reviewed by Cursor Bugbot for commit 0b730a0. Bugbot is set up for automated code reviews on this repo. Configure here.