[GRAPH-1102] Customizable doc storage with default implementation#10
Open
[GRAPH-1102] Customizable doc storage with default implementation#10
Conversation
bryanjos
commented
Jun 21, 2024
GeoffreyPS
reviewed
Jun 21, 2024
GeoffreyPS
left a comment
There was a problem hiding this comment.
I left some feedback on things that confused me or seemed a little awkward.
I think exposing this as a behavior is a great idea, so I agree with the direction you're taking this.
Contributor
Author
|
@benwilson512 @maartenvanvliet Hey we're looking to add support for customizing how Absinthe stores subscription documents in our fork. But we also want to make sure it's going in a direction that it can be added into Absinthe proper. Do you all mind looking and giving any feedback? |
Contributor
Author
|
I think I might have overthought this. Instead, people can just implement the behaviour, tell Absinthe what module to use and then they can start any processes they need before starting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Absinthe.Subscription.DocumentStorageto allow customization around how Absinthe stores subscription documents and field key pairs.Absinthe.Subscription.DefaultDocumentStorageimplemented using the Registry and algorithms Absinthe used previouslyAbsinthe.Subscription.Supervisorto check for astoragekey in itsopts. The default value isAbsinthe.Subscription.DefaultDocumentStorageAbsinthe.Subscriptionto use the configured storage module