Skip to content

Conversation

@cmdoug
Copy link
Contributor

@cmdoug cmdoug commented Dec 12, 2025

Attempt to fix #371 reported by @echarala.

@cmdoug cmdoug changed the base branch from master to develop December 12, 2025 02:54
@cmdoug cmdoug changed the title Separate near nullspace Separate nullspace and nearnullspace Dec 12, 2025
@prj-
Copy link
Member

prj- commented Dec 12, 2025

LGTM, @echarala, could you please confirm this fixes your issue?

@echarala
Copy link

Yes, it should. I will try it in my problem. Nice fix, guys!

@cmdoug
Copy link
Contributor Author

cmdoug commented Dec 15, 2025

@prj- note that the CI pipeline didn’t auto-run for this PR yet. It passes make check on my end, though.

@prj-
Copy link
Member

prj- commented Dec 15, 2025

Yeah, there is no reason to have it fail make check, since the code (or the combination of both null spaces) is largely untested. It would be nice to have a minimalist example that combines both and that was previously failing, but I'm guessing it may be a little bit difficult to extract from your code, @echarala? BTW, I'm waiting on your confirmation to get this integrated, so please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Providing both nullspace and nearnullspace in KSPSolve does not work

3 participants