-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add CFI frame unwind info in portable/IAR/RXv2/port_asm.s #1341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bernd-edlinger
wants to merge
1
commit into
FreeRTOS:main
Choose a base branch
from
bernd-edlinger:add_cfi_frame_unwind_info
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bernd-edlinger ,
I have a quick question regarding resource naming: does the '?' have any specific meaning? I checked the manual, but I couldn’t find any clear guidelines on naming conventions or common practices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is apparently the name of the return address, I have not found it in any documentation either...
I saw this syntax in the assembler files, generated by the IAR compiler when I added the option
-la .to save the intermediate assembler file with debug info generated by the compiler. Some of the
interrupts are written in C with syntax like
__interrupt void vTickISR( void )etc.But the
?RETis used everywhere, normal functions have the return addess atFrame(CFA, -4)and Interrupts have it at
Frame(CFA, -8)while atFrame(CFA, -4)is probably the interruptedprocessor flags or something that the debugger does not care about for the call stack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bernd-edlinger , thank you for your response.
I understand that the name is based on one generated by the IAR compiler. In that case, there should be no problem.
I don't have sufficient knowledge about the CFI of the IAR compiler, so this is just a guess, but here is what I assume. Please refer to the RX Instruction Set Architecture manual, especially the
JSRandINTinstructions:Frame(CFA, -4)in normal functions represents the stack area used to store the caller's PC register.Frame(CFA, -8)in interrupts represents the stack area used to store the PC and PSW registers from immediately before the interrupt.