Conversation
The training and inference scripts had data/scaler/checkpoint paths hardcoded to developer home directories on GCP VMs. These are now configurable via command-line arguments, with the original values retained as defaults. Also wraps both scripts in proper main() functions and removes commented-out dead code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code cleanup and hygiene improvements:
supermag_web_deployment_old_.py, data_sources_old_.py) and unused generate_data.py
sheath_train_embeddings.py, sheath_feature_vector*.py), making them runnable outside the original dev environment
docstrings across scripts