refactor: remove the visibility property from documents and pages

[Kenny806]

Removing the visibility property from Document and DocumentPage. As the property is never actually returned from our APIs, it is always undefined and we do not have any use case for it at the moment. This also removes a lie from our type definitions :-)

[changeset-bot]

🦋 Changeset detected

Latest commit: 589034c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@frontify/guideline-blocks-settings	Patch
@frontify/app-bridge	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[sonarqubecloud]

Quality Gate passed for 'App Bridge'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[ragi96]

This is a breaking change please do it on the dev branch (we then just need to think about how we wanna map that, for v3)

[Kenny806]

This is a breaking change please do it on the dev branch (we then just need to think about how we wanna map that, for v3)

@ragi96 Is it? The value is never populated and is always undefined. If anyone was ever trying to read document.visibility, they always got undefined. And they will continue to get undefined even after this is merged. Or am I missing something here?

[ragi96]

This is a breaking change please do it on the dev branch (we then just need to think about how we wanna map that, for v3)

@ragi96 Is it? The value is never populated and is always undefined. If anyone was ever trying to read document.visibility, they always got undefined. And they will continue to get undefined even after this is merged. Or am I missing something here?

Really? 😆
I need to check it out quickly :)

[ragi96]

Finally had time to retest and imo it's still a breaking change:

Feel free to remove it in v4 and map it to something static in the web-app, but we can't change this production type.