create storage for too-large images (and to keep them across sessions)#67
Open
essential-randomness wants to merge 2 commits intomainfrom
Open
create storage for too-large images (and to keep them across sessions)#67essential-randomness wants to merge 2 commits intomainfrom
essential-randomness wants to merge 2 commits intomainfrom
Conversation
✅ Deploy Preview for astrolabe-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
virtuous-cat
approved these changes
Mar 3, 2026
Collaborator
virtuous-cat
left a comment
virtuous-cat
left a comment
There was a problem hiding this comment.
Looks good!
There's one section that looks like some clean up got undone in a conflict resolution or something, but I will leave it to you to decide whether to fix it here or merge this first.
| images.forEach(async (image) => { | ||
| const file = await imageToFile(image.src); | ||
| insertImage({ editor, file }); | ||
| const parsedDoc = new DOMParser().parseFromString( |
Collaborator
There was a problem hiding this comment.
I feel like the changes in this function are maybe a regression except for the adding of the processorConfig to the insertImage arguments? The "old" version is more readable and seems like something that was cleaned up after the branches diverged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it so we can resize images once they're pasted in the editor (my editor was struggling when i pasted too many too large images).
I would avoid reviewing plugins/hyperimage/src/indexed-db-image-store.ts (maybe?) and plugins/hyperimage/stories/StorageDebugPanel.tsx cause either boilerplate mostly (the first one) or the worst react code i threw together cause i needed to figure out if this was working.