Skip to content

Conversation

@G-Rath
Copy link
Owner

@G-Rath G-Rath commented Oct 31, 2024

In addition to this shaving ~100kb off the binary, it also means GoLand understands there are string formatting functions since they follow the Sprintf pattern 🎉

@G-Rath G-Rath force-pushed the replace-color branch 2 times, most recently from 2cd5af6 to b794a1a Compare January 21, 2025 18:29
@G-Rath
Copy link
Owner Author

G-Rath commented Feb 10, 2025

CI is currently failing because go-pretty currently does not automatically try to detect color support, so the color codes are being outputted in the test suite and its snapshots.

I have opened jedib0t/go-pretty#352 for this

@G-Rath G-Rath force-pushed the replace-color branch 2 times, most recently from 33cfebf to c838d06 Compare April 3, 2025 18:20
@G-Rath G-Rath force-pushed the replace-color branch 2 times, most recently from f554acb to 51f0206 Compare August 20, 2025 20:55
@G-Rath G-Rath force-pushed the replace-color branch 2 times, most recently from 25a7d48 to 0133ff2 Compare November 12, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants