-
Notifications
You must be signed in to change notification settings - Fork 101
feat: Split statistics components computation & output #3836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MelReyCG
wants to merge
327
commits into
develop
Choose a base branch
from
bugfix/rey/split-statistics-components
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
327 commits
Select commit
Hold shift + click to select a range
4811b6c
Unit test implemented
amandinehry 4a8ea5b
evaluate MSG only one time in macros
amandinehry 2b38577
Merge commit '7e85e747ec65cd498ba0e9e4730f79d2692ed0bd' into feature/…
MelReyCG 127f38e
Merge branch 'feature/amandinehry/create-yaml-file-and-structure' of …
amandinehry e9508f5
Merge remote-tracking branch 'upstream/develop' into feature/amandine…
amandinehry 7fc0ced
🔊 warn the deveveloppers that a yamlFile should not be written if not…
MelReyCG 35f7686
🐛 ⏪ set the --errorsOutput mandatory because of bug + revert optionpa…
MelReyCG 31842a5
✏️ typo
MelReyCG a1105e4
🎨 uncrustify
MelReyCG c118dd4
🎨 docs alignement
MelReyCG 4215fad
🎨 format
MelReyCG 507ac66
builder pattern for addContextInfo
MelReyCG 7b4ec52
♻️ refactor of the test: keeping only necessary testing, separated te…
MelReyCG a01d8ac
🐛 bugfix for test, wrong global instance impacting
MelReyCG d4c465b
🎨 format
MelReyCG 1e32d65
Merge remote-tracking branch 'origin/develop' into feature/amandinehr…
MelReyCG 6d10e3a
⏪ restored "Rank N:" if error messages
MelReyCG e9cd64c
test
amandinehry c7031bf
Merge branch 'feature/amandinehry/create-yaml-file-and-structure' of …
amandinehry e07d0b7
uncomment the rmoveFile() function
amandinehry 785636b
stack trace management
amandinehry dd3b844
Merge remote-tracking branch 'amandinehryFork/develop' into feature/a…
MelReyCG e0bad67
♻️ ✅ New GEOS_ERROR macros with context included + new unit macro uni…
MelReyCG ab40edc
✅ ♻️ Simplifying + testing macros (GEOS_ERROR_* and GEOS_ASSERT_*) + …
MelReyCG faa84fa
📝 adding macro docs
MelReyCG dd97f0e
✨ ✅ adding error cause in unit test
MelReyCG d708cac
♻️ reordered error & throw macro to group them
MelReyCG 66ab5cb
♻️ ✅ uniformized warning macros
MelReyCG e6135b1
✅ 🐛 ⚡️ bugfix when callstack is empty + disable callstack for perfs
MelReyCG 589fcfe
♻️ ✅ uniformized throw macros
MelReyCG 6fc4b30
✅ removing _CTX macros from unit test
MelReyCG 77f9fcb
🐛 use streamed cause string to support mpi pointers formatting (not s…
MelReyCG 5747e7f
🐛 last mistake?
MelReyCG 10eb969
♻️ removing all GEOS_*_CTX macros (as GEOS_ERROR, GEOS_WARNING, GEOS_…
MelReyCG 2c5c5f5
🎨 UNCRUSTIFY
MelReyCG d1642e6
Merge remote-tracking branch 'origin/develop' into feature/amandinehr…
MelReyCG b3cbb99
Merge remote-tracking branch 'origin/develop' into feature/amandinehr…
MelReyCG 5781a78
✨ allowing to re-throw with GEOS_THROW* macros
MelReyCG db75e45
📦 shema
MelReyCG e07ab72
♻️ removing unintended BASE::
MelReyCG cd67768
change validation for region statistics for by resvol constraint
tjb-ltk 5ced2b7
rel mode compile fix
tjb-ltk b2cbc13
check if reference region defined
tjb-ltk 754ed03
Merge remote-tracking branch 'origin/develop' into refactor/dudes/err…
arng40 83d0c0f
xsd
arng40 d5d8615
Merge remote-tracking branch 'origin/feature/amandinehry/create-yaml-…
arng40 1913059
🎨 uncrustify
MelReyCG 6692dd2
🐛 fix stream reset
MelReyCG 29f6fbe
⚰️ unused variable
MelReyCG d17972f
✨ removing last LVARRAY_* error logging macros
MelReyCG 759e9bb
Merge remote-tracking branch 'origin/develop' into feature/amandinehr…
MelReyCG 1b755b5
✨ removing last LVARRAY_* error logging macros
MelReyCG 3786db4
✅ adapting test with error cause addition
MelReyCG efa89d8
🐛 GPU Macros Support
MelReyCG 7915205
🎨 uncrustify
MelReyCG 14eefee
Merge branch 'develop' into feature/amandinehry/create-yaml-file-and-…
MelReyCG c0f8148
Merge remote-tracking branch 'origin/fix/byer3/resvolconstraint_valid…
MelReyCG 500bbfd
🐛 GPU forgotten instruction
MelReyCG fa8fa54
🐛 added pragmas to manual shadow global logger instance
MelReyCG a29510b
Merge branch 'feature/amandinehry/create-yaml-file-and-structure-2' o…
MelReyCG c501a0f
🐛 wrong conversion on GPU
MelReyCG a07810f
Merge branch 'develop' into feature/amandinehry/create-yaml-file-and-…
MelReyCG cbb5322
centralize error output
arng40 c743e15
remvove deplucated log
arng40 dc13b33
Merge remote-tracking branch 'origin/feature/amandinehry/create-yaml-…
arng40 355e765
remove rank from arg
arng40 276606c
Merge remote-tracking branch 'origin/develop' into refactor/dudes/err…
arng40 3253a0b
fix after merge
arng40 cf0afc5
doc & fix
arng40 efcc52d
fix test
arng40 79b9791
test error
arng40 d951a16
initialize m_time
arng40 29dec26
add main for testUnits
arng40 6be688c
missing std::cout
arng40 62fa7ec
Merge remote-tracking branch 'origin/develop' into refactor/dudes/err…
arng40 5f9c74c
Merge remote-tracking branch 'origin/develop' into refactor/dudes/err…
arng40 95f631e
uncrust
arng40 df926d5
remove unecessary var
arng40 07b649a
doxygen
arng40 2fee6bf
clean
arng40 93594af
output only once
arng40 e430ae8
add "__" prefix
arng40 d5408c9
doxygen
arng40 17a394a
remove var duplication
arng40 061f502
fix format
arng40 450c3b0
add line number
arng40 d0ff49d
add stream to errorlogger + rename macro in logger
arng40 628e49c
reove debug log
arng40 f09d45f
fix test & cleanup
arng40 ec1feab
remove unecassery dep
arng40 419ba18
Merge branch 'develop' into refactor/dudes/error-context
arng40 9d5db85
fix test
arng40 2c9d6ce
Merge branch 'refactor/dudes/error-context' of https://github.com/GEO…
arng40 8708f2d
add geos::exception + refacto flushErrorMsg
arng40 3842caa
update exception inGEOS_THROW to geos::Exception
arng40 ae0b73c
update what() method
arng40 96bab37
remove unecessary cond
arng40 f47e62e
renaming and remove try catch from main
arng40 9289b82
add GeosExceptions
arng40 694e64e
clean up
arng40 b083853
remove unecessary include + some doc
arng40 b13149d
Merge remote-tracking branch 'origin/develop' into refactor/dudes/err…
arng40 e1b45f4
missong doc for GeosException
arng40 7771fbe
🚧 wip 1
MelReyCG 37d75e5
🚧wip 2
MelReyCG 202b6fc
Merge remote-tracking branch 'origin/develop' into bugfix/rey/split-s…
MelReyCG 239ff24
🚧 applying merge change to task component
MelReyCG 976aab5
include error
arng40 42c53b9
doxygen
arng40 16c9e77
update doxy
arng40 30baf23
remove include, + some clean
arng40 0aeddcf
fix cuda compil
arng40 ae60c25
move writeToAscii to cpp
arng40 5a52a75
doxygen
arng40 9ff68f4
♻️ uncoupling regions and statistics data storage (WIP, data could be…
MelReyCG 15369ed
🐛 map alloc bugfix
MelReyCG c48c52d
add log test
arng40 bbb72ff
fix log wrong formatting
arng40 855cf80
update log formatting & output
arng40 daec006
fix test
arng40 ab9895b
Uncrustify
arng40 60a1f3a
Merge branch 'develop' into refactor/dudes/error-context
arng40 4e74b00
Merge branch 'develop' into refactor/dudes/error-context
arng40 08973a3
reorder function + add constructor to ErrorContext
arng40 cee0059
uncrustify & doxygen
arng40 2a639a7
Merge branch 'develop' into refactor/dudes/error-context
arng40 a2b31d1
Merge branch 'develop' into refactor/dudes/error-context
arng40 d4db78b
improve writeToAscii
arng40 7df78ff
add context to std::exception
arng40 abc6d2a
fix encapsulation in ErrorLogger by adding BuilderPattern + improve c…
arng40 ec7ddc1
uncrustify
arng40 4a5b4fe
remove redundant lmsg in case of multiple rank
arng40 35d8707
missing const
arng40 38023c2
delete ErrorMsg method & remove unecessary method in Builder
arng40 f5affb5
🚧different data structures plan
MelReyCG c257445
🚧choosing the plan that seem like the best one
MelReyCG 62fcf31
extract inerclass & refacto ErrorBuilder
arng40 856a6c7
♻️moved stat so each aggregator has its own data in the data reposito…
MelReyCG 1495a68
rename ErrorMsg & adapt errorLogger function called in catch
arng40 1c4b603
♻️impact new aggregator on stats task + bugfixes on formatting & output
MelReyCG a4e69cd
modify yaml & renaming & fix
arng40 16057c1
remove debug log
arng40 3ed52be
update prepareWhat
arng40 e40167f
update builder
arng40 b529d7a
rename get method & sort errorContext
arng40 ec4703c
remove debug
arng40 fbed3ed
update format
arng40 69dfad7
🔊 better messages & naming
MelReyCG 55c0eeb
♻️continue refactorings before solvers usages
MelReyCG ccfede6
📝 a bit of docs
MelReyCG f92b9f7
🚧 draft of application on well solvers
MelReyCG c295ff7
♻️element manager -> meshlevel in parameters
MelReyCG 8fdf42c
✨ implement statistics aggregator call from wellcontrols
MelReyCG 3102971
Merge remote-tracking branch 'origin/develop' into bugfix/rey/split-s…
MelReyCG ae978a2
🐛compil fixes
MelReyCG e8682c7
add signal test
arng40 cf1c00f
update initCurrentExcep + add GeosExcp msg + update test
arng40 4ce27d2
⚰️ pruning headers
MelReyCG 3288270
🐛bugfix bad type detection
MelReyCG 753d32b
🐛 flash pressure computing bugfix
MelReyCG aa9d539
add signal test + last remarks
arng40 6adbae1
Merge remote-tracking branch 'origin/develop' into refactor/dudes/err…
arng40 b351784
doxygen
arng40 588084d
uncristify
arng40 c2bc1aa
📦schemamehcs
MelReyCG 535e87f
small refacto
arng40 ff2f3fa
alignment
arng40 359f256
fix review
arng40 a942101
relocation
arng40 b528427
fix signal test
arng40 5eb71ce
format
arng40 0a5af00
add mutex
arng40 1b7fab5
♻️centralize flowSolver access
MelReyCG ea56eb8
doxygen
arng40 da560e1
🎨 formating consistency
MelReyCG 456e767
add yaml mutex
arng40 44a54d8
doxygen
arng40 6f444d6
thread_local put back + renaming
arng40 7015589
renaming
arng40 ffbfe25
🐛 better last-time validation (div/0 avoided?)
MelReyCG 0394da8
🐛 accessing the right region data structure + added validations + bet…
MelReyCG d7c3ab0
💄better stats table (TODO justify titles left)
MelReyCG 44e3c3e
🐛 initialized reference reservoir pressure stats at implicitStepSetup…
MelReyCG 18abaed
🐛 attempt to manage stats dirtyness for recomputation for timestep cuts
MelReyCG c886b9e
Merge branch 'develop' into refactor/dudes/error-context
MelReyCG 9022c87
Merge remote-tracking branch 'origin/refactor/dudes/error-context' in…
MelReyCG 99849aa
🐛simple compil fix
MelReyCG dd11209
💄adding forgotten space line at end of message
MelReyCG 365affa
Merge remote-tracking branch 'origin/refactor/dudes/error-context' in…
MelReyCG f3c4bc7
💄small layout proposal
MelReyCG 6318a57
Merge remote-tracking branch 'origin/refactor/dudes/error-context' in…
MelReyCG 1cda08b
Merge branch 'develop' into refactor/dudes/error-context
arng40 d8ef456
uncrustify
arng40 d6f00ac
Merge branch 'refactor/dudes/error-context' of https://github.com/GEO…
arng40 3a1983b
Merge branch 'develop' into refactor/dudes/error-context
arng40 59ad659
attempt clang bug
arng40 4298b30
uncr
arng40 a87eb1a
Merge branch 'develop' into refactor/dudes/error-context
arng40 fb86478
Merge branch 'develop' into refactor/dudes/error-context
arng40 e576151
update doxygen
arng40 22b4ae9
update some doxygen on errorhandling
arng40 ddffc5f
add FE_ALL_EXCEPT
arng40 56956c4
🔇 remove debug logs
MelReyCG d57dc3a
Merge remote-tracking branch 'origin/refactor/dudes/error-context' in…
MelReyCG ba56689
remove line break
arng40 a29a873
Merge remote-tracking branch 'origin/refactor/dudes/error-context' in…
MelReyCG 7569391
🐛
MelReyCG 152b215
🐛 solve warning bug
MelReyCG e801605
🔇 remove logs
MelReyCG e39c7e5
🔇 less logs when no ref region is set
MelReyCG 90ec8e8
Merge remote-tracking branch 'origin/develop' into bugfix/rey/split-s…
MelReyCG 9891041
Merge remote-tracking branch 'origin/develop' into bugfix/rey/split-s…
MelReyCG cd0bd92
⏪revert wrong file modif
MelReyCG 30eebad
🚧wrongly removed the !useSurfaceCondition?
MelReyCG 30c667c
♻️ renamed flashConditions -> refConditions
MelReyCG 5c0fb3a
Abstracting statistics aggregator with CRTP
MelReyCG 4961b0c
⚰️useless header
MelReyCG afabaf8
⚰️ useless usings
MelReyCG 64bf05d
⚰️ old commented / useless code
MelReyCG 7b36093
🚨 forgotten headers in cmakelists
MelReyCG 419ec9d
⚰️useless includes
MelReyCG 53a3971
🔊better error logging
MelReyCG 6f6215d
reduce allocations
MelReyCG 7005835
📝side note
MelReyCG 4a26191
✨ generalizing aggregator call to singlephase cases
MelReyCG 64b3798
🔊log the real view key
MelReyCG cedbac7
🐛fix single phase flow unit test
MelReyCG 94e07ed
✅consolidated flow unit test by also testing total mass balance of co…
MelReyCG 6a9fbb1
file docs
MelReyCG 27f1e47
🎨clearer output : full discretization before each regions + adapted l…
MelReyCG 071b65a
Merge branch 'develop' into bugfix/rey/split-statistics-components
MelReyCG db37bf0
⚰️ removal of uml schemas
MelReyCG 7aea764
Merge remote-tracking branch 'origin/develop' into bugfix/rey/split-s…
MelReyCG 22c8ad7
♻️remove unnecessary solver reference
MelReyCG f92526f
🎨crucrustify
MelReyCG 8d8d978
✨ optional hdf5 output
MelReyCG 98e8006
✨reduce warning amount
MelReyCG e715ebf
⚰️ unused capture
MelReyCG bfaca9a
🐛wrong std::move usage
MelReyCG 8fa32e0
✅rebaseline
MelReyCG 395d42f
💄better region/discretisation display
MelReyCG 9310df0
🐛 Fix lacks of calling for stats recomputation at start of timestep
MelReyCG 6ae1a2e
♻️ remove template
MelReyCG 899dcc9
✨ component formatting
MelReyCG 597ae91
♻️ removed getTotalFluidMass specialization (generalized total mass i…
MelReyCG 3c33fd8
Merge remote-tracking branch 'origin/develop' into bugfix/rey/split-s…
MelReyCG d148974
✅ rebaseline (verified: purely structural, no numerical difference)
MelReyCG 7c017f1
✅ update rebaseline hash
MelReyCG 16cbaff
Merge remote-tracking branch 'origin/develop' into bugfix/rey/split-s…
MelReyCG 8627632
✅ update rebaseline hash
MelReyCG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is a PreparedTableLayout vs presumably an "non" PreparedTableLayout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
TableLayoutis the descriptor of the desired layout, and thePreparedTableLayouthas precomputed data for optimizing further ascii formatting.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does that answer?