feat: generalize use of sparse matrices in kernels#3989
Closed
rrsettgast wants to merge 45 commits into
Closed
Conversation
rrsettgast
requested review from
OmarDuran,
andrea-borio,
castelletto1,
frankfeifan and
jhuang2601
as code owners
rrsettgast
added
the
ci: run integrated tests
rrsettgast
changed the title
rrsettgast
requested review from
cssherman,
dkachuma,
tjb-ltk and
victorapm
as code owners
dkachuma
approved these changes
Apr 14, 2026
rrsettgast
added
ci: run CUDA builds
Remove the DefaultGlobalMatrixView default from ImplicitKernelBase, InterfaceKernelBase, and SparsityKernelBase, and delete the FirstMatrixViewOrDefault / FirstInterfaceMatrixViewOrDefault SFINAE helpers that silently picked a matrix view from the constructor argument pack. KernelFactory and InterfaceKernelFactory now take MATRIX_VIEW as an explicit template parameter; all 24 affected factory aliases pass DefaultGlobalMatrixView at the call site. This makes the failure mode loud and grep-able for the upcoming hypre ParCSRMatrix view in the private repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generalizes the kernels to use/take generic matrix types.