Skip to content

fix: compilation issue with HIP build#3990

Merged
castelletto1 merged 1 commit intodevelopfrom
bugfix/paludettomag1/tuo-build
Mar 5, 2026
Merged

fix: compilation issue with HIP build#3990
castelletto1 merged 1 commit intodevelopfrom
bugfix/paludettomag1/tuo-build

Conversation

@victorapm
Copy link
Contributor

Follow-up to PR #3831

Fixes one remaining build issue not addressed in the previous PR:

In file included from geos-path/src/coreComponents/constitutive/fluid/multifluid/CO2Brine/CO2BrineFluid.cpp:19:
In file included from geos-path/src/coreComponents/constitutive/fluid/multifluid/CO2Brine/CO2BrineFluid.hpp:29:
geos-path/src/coreComponents/constitutive/fluid/multifluid/CO2Brine/functions/CO2Solubility.hpp:196:26: error: reference to __host__ function 'format<const double &, const double &>' in __host__ __device__ function
  196 |                          GEOS_FMT( "Failed to calculate solubility at pressure {} Pa and temperature {} C.", pressure, temperature ) );
      |                          ^
geos-path/src/coreComponents/common/format/Format.hpp:81:43: note: expanded from macro 'GEOS_FMT'
   81 | #define GEOS_FMT( msg, ... ) GEOS_FMT_NS::format( msg, __VA_ARGS__ )
      |                                           ^
geos-path/src/coreComponents/constitutive/fluid/multifluid/CO2Brine/CO2BrineFluid.hpp:289:11: note: called by 'compute'
  289 |   m_flash.compute( pressure,
      |           ^
/usr/WS1/GEOS/GEOSX/TPLs_2026-03-02/tuolumne-llvm-amdgpu-6.4.3_tpls/llvm-amdgpu-6.4.3/fmt-11.0.2-vjwb72ugeomwqz4kcgt64id6mnkgqzhp/include/fmt/format.h:4363:31: note: 'format<const double &, const double &>' declared here
 4363 | FMT_NODISCARD FMT_INLINE auto format(format_string<T...> fmt, T&&... args)
      |                               ^
In file included from geos-path/src/coreComponents/constitutive/fluid/multifluid/CO2Brine/CO2BrineFluid.cpp:19:
In file included from geos-path/src/coreComponents/constitutive/fluid/multifluid/CO2Brine/CO2BrineFluid.hpp:29:
geos-path/src/coreComponents/constitutive/fluid/multifluid/CO2Brine/functions/CO2Solubility.hpp:196:36: error: reference to __host__ function 'basic_format_string<char[71], 0>' in __host__ __device__ function
  196 |                          GEOS_FMT( "Failed to calculate solubility at pressure {} Pa and temperature {} C.", pressure, temperature ) );

@victorapm victorapm self-assigned this Mar 5, 2026
@victorapm victorapm requested a review from dkachuma as a code owner March 5, 2026 01:54
@victorapm victorapm added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline ci: run code coverage enables running of the code coverage CI jobs labels Mar 5, 2026
@victorapm victorapm requested a review from castelletto1 March 5, 2026 01:54
@castelletto1 castelletto1 merged commit fe5252e into develop Mar 5, 2026
21 of 22 checks passed
@castelletto1 castelletto1 deleted the bugfix/paludettomag1/tuo-build branch March 5, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants