Skip to content

Avoid method hiding warning#4059

Open
dkachuma wants to merge 1 commit into
developfrom
dkachuma/avoid-function-hiding
Open

Avoid method hiding warning#4059
dkachuma wants to merge 1 commit into
developfrom
dkachuma/avoid-function-hiding

Conversation

@dkachuma
Copy link
Copy Markdown
Contributor

On GPU builds I was getting many warnings of the form

src/coreComponents/constitutiveDrivers/fluid/multiFluid/PVTDriver.hpp(50): warning #997-D: function "geos::ExecutableGroup::execute(geos::real64, geos::real64, geos::integer, geos::integer, geos::real64, geos::DomainPartition &)" is hidden by "geos::PVTDriver::execute" -- virtual function override intended?
    bool execute() override;
         ^

This change makes it more explicit to avoid this warning.

@dkachuma dkachuma self-assigned this May 14, 2026
@dkachuma dkachuma added type: cleanup / refactor Non-functional change (NFC) ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline ci: run code coverage enables running of the code coverage CI jobs labels May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review type: cleanup / refactor Non-functional change (NFC)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants