refactor: Refactor geos-mesh test and test meshes#237
Open
RomainBaville wants to merge 22 commits intomainfrom
Open
refactor: Refactor geos-mesh test and test meshes#237RomainBaville wants to merge 22 commits intomainfrom
RomainBaville wants to merge 22 commits intomainfrom
Conversation
RomainBaville
added
flag: ready for review
type: cleanup
test-geos-integration
Comment on lines
306
to
309
| globalIds: vtkDataArray = data.GetGlobalIds() if data.GetGlobalIds() is not None else data.GetArray( | ||
| "localToGlobalMap" ) | ||
| if globalIds is None: | ||
| raise AttributeError( "There is no GlobalIds in the given fieldData." ) |
Collaborator
There was a problem hiding this comment.
This error might be captured by the VTKError to prevent this test with "is None"
Contributor
Author
There was a problem hiding this comment.
It is not a vtkError, If the mesh has no globalIds, the function getGlobalIds will return a None object not an error. I have nonetheless update the error managment to be mor informative
Co-authored-by: paloma-martinez <104762252+paloma-martinez@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to refactor the tests of geos-mesh to:
As the meshes from the GEOS simulation are the same than thos used in geos-proceesing and geos-processing is depending of geos-mesh, all the meshes are moved in geos-mesh
This PR close #238