More tests#31
Open
craigmillernz wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 64.76% 67.51% +2.75%
==========================================
Files 22 22
Lines 3780 3780
Branches 793 793
==========================================
+ Hits 2448 2552 +104
+ Misses 1071 963 -108
- Partials 261 265 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new pytest coverage around GSolve’s report assembly/Excel export flow and the core least-squares solver functions, aiming to catch regressions in validation, branching, and terrain-correction consistency logic.
Changes:
- Add
GSolveReporttests for table assembly, parameter sections, terrain-correction consistency checks, andto_excel()sheet-writing behavior. - Add
call_gsolve_lstsq/g_solver_lstsqtests for input validation, calibration-factor paths, loop handling branches, and percentile-clipping behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
tests/test_reports.py |
New tests covering report assembly, terrain-correction consistency, and Excel export behavior. |
tests/test_gsolve_algorithms.py |
New tests covering solver validations/branches and percentile clipping behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got Claude to add extra tests where needed.