Skip to content

More tests#31

Open
craigmillernz wants to merge 4 commits into
mainfrom
more-tests
Open

More tests#31
craigmillernz wants to merge 4 commits into
mainfrom
more-tests

Conversation

@craigmillernz
Copy link
Copy Markdown
Collaborator

I got Claude to add extra tests where needed.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.51%. Comparing base (9d0cb2e) to head (42265f0).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   64.76%   67.51%   +2.75%     
==========================================
  Files          22       22              
  Lines        3780     3780              
  Branches      793      793              
==========================================
+ Hits         2448     2552     +104     
+ Misses       1071      963     -108     
- Partials      261      265       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new pytest coverage around GSolve’s report assembly/Excel export flow and the core least-squares solver functions, aiming to catch regressions in validation, branching, and terrain-correction consistency logic.

Changes:

  • Add GSolveReport tests for table assembly, parameter sections, terrain-correction consistency checks, and to_excel() sheet-writing behavior.
  • Add call_gsolve_lstsq / g_solver_lstsq tests for input validation, calibration-factor paths, loop handling branches, and percentile-clipping behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
tests/test_reports.py New tests covering report assembly, terrain-correction consistency, and Excel export behavior.
tests/test_gsolve_algorithms.py New tests covering solver validations/branches and percentile clipping behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_reports.py
Comment thread tests/test_reports.py Outdated
Comment thread tests/test_reports.py Outdated
Comment thread tests/test_reports.py Outdated
Comment thread tests/test_reports.py Outdated
Comment thread tests/test_reports.py Outdated
craigmillernz and others added 2 commits May 28, 2026 17:59
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants