refactor: graph monitor & some handles#383
Merged
eigmax merged 2 commits intoGOATNetwork:devfrom Feb 10, 2026
Merged
Conversation
eigmax
reviewed
Feb 10, 2026
| pub require_disproved_indexes: Vec<usize>, | ||
| pub commit_blockhash_status: CommitBlockHashStatus, | ||
| pub is_challenge_timeout_sent: bool, | ||
| pub is_challenge_timeout_sent: bool, // deprecated |
eigmax
reviewed
Feb 10, 2026
| @@ -296,25 +305,27 @@ impl WTInitTxVoutMonitorData { | |||
| .filter(|(_, v)| { | |||
| **v == WatchtowerChallengeItemStatus::Challenge | |||
eigmax
reviewed
Feb 10, 2026
| || self.commit_blockhash_status == CommitBlockHashStatus::OperatorCommitTimeout | ||
| } | ||
|
|
||
| pub fn check_watchtower_challenge_normal_finished(&self) -> bool { |
Contributor
There was a problem hiding this comment.
check_watchtower_challenge_normal_finished => check_watchtower_challenge_finished
eigmax
reviewed
Feb 10, 2026
| return Ok(true); | ||
| } | ||
| if vout_monitor_data.is_disproved() { | ||
| let challenge_start_txid = graph.challenge_txid.clone().map(|v| v.into()); |
Contributor
There was a problem hiding this comment.
it needs .collect to get the result.
eigmax
reviewed
Feb 10, 2026
| false, | ||
| graph.graph_id, | ||
| None, | ||
| "self".to_string(), |
Contributor
There was a problem hiding this comment.
can we change this to a global variable or an enum variable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.