Skip to content

Renew Replenisher#435

Merged
Dream-Master merged 10 commits into
masterfrom
update-replenisher
May 27, 2026
Merged

Renew Replenisher#435
Dream-Master merged 10 commits into
masterfrom
update-replenisher

Conversation

@lc-1337
Copy link
Copy Markdown

@lc-1337 lc-1337 commented May 14, 2026

Use new slots.
Count storage on update. Use I/O operations log not reliable.

@Kogepan229
Copy link
Copy Markdown
Member

GTNewHorizons/Applied-Energistics-2-Unofficial#1317
Would this be unusable?

Also, create a new class instead of using VirtualMEPatternSlot.

Copy link
Copy Markdown
Member

@Kogepan229 Kogepan229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't onChangeInventory set needReCountStoredItems to true, and onFluidInventoryChanged set needReCountStoredFluids to true?

@lc-1337
Copy link
Copy Markdown
Author

lc-1337 commented May 25, 2026

@Kogepan229 I think i cant trust onChange calls backs, so on start of re-stock we calculate current storage, needReCount* need only for prevent re count for next slot in current re stock.

@Kogepan229
Copy link
Copy Markdown
Member

@Kogepan229onChange コールバックは信頼できないと思うので、補充の開始時に現在のストレージを計算します。needReCount* は、現在の補充の次のスロットの再カウントを防ぐためだけに必要です。

If so, there is a problem.

At the end of fletchFluids(), needReCountStoredFluids is set to true, but if getFreeBytes() is called later inside fletchItems(), the fluid count will be recalculated and the flag will be set back to false.
If fluids are then drained externally in that state, the next restock may end up using a stale fluid count.

@lc-1337
Copy link
Copy Markdown
Author

lc-1337 commented May 25, 2026

i see, i moved reset to end of tick request

Comment thread src/main/java/com/glodblock/github/inventory/AEFluidInventory.java Outdated
Copy link
Copy Markdown
Member

@Kogepan229 Kogepan229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are last comments

Comment thread src/main/java/com/glodblock/github/common/tile/TileSuperStockReplenisher.java Outdated
@lc-1337
Copy link
Copy Markdown
Author

lc-1337 commented May 25, 2026

@Kogepan229 Done, but i would like also use new "zero void" module for this. When it(module) will be merged ofc.

@Dream-Master Dream-Master merged commit 0a84d20 into master May 27, 2026
1 check passed
@Dream-Master Dream-Master deleted the update-replenisher branch May 27, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants