You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@GregorySchwartz: The main difference is that in the streaming version the outer step' function immediately passes each complete Line to the inner step function here:
-- Emit each complete `Line`
x' <- foldM step x (NonEmpty.init lines')
... before moving on to the next Text chunk. In particular, the streaming version does not store the complete sequence of Lines inside of the accumulator as a Shell Line.
Passing completed Lines to the inner step function immediately instead of holding onto them ensures that even if there are a large (or infinite) number of output Lines then the toLines function still makes progress and doesn't wait until computing all of the Lines to begin forwarding them downstream.
I'll go ahead and merge #356, then. However, I'd still like you to review #357 if you can to see if it addresses your use case before merging that one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #354. Probably needs a better name, should avoid partial functions, and needs verification if bang patterns are needed, especially on
stream.