Skip to content

fix: raise errors for invalid shears and PixelScale WCS inits#242

Draft
beckermr wants to merge 6 commits into
mainfrom
equinox-errs
Draft

fix: raise errors for invalid shears and PixelScale WCS inits#242
beckermr wants to merge 6 commits into
mainfrom
equinox-errs

Conversation

@beckermr
Copy link
Copy Markdown
Collaborator

@beckermr beckermr commented May 14, 2026

This PR adds runtime init error checking to the Shear class. It uses the equinox.error_if function. The net result is that the code now raises for invalid shears. Unfortunately there is no way to raise exceptions besides the equinox.EquinoxRuntimeError and according to the equinox issue tracker, enabling custom exceptions is not a feature they plan to support. We can't use subclassing IIUIC because the inheritance goes the wrong way.

xref: #237

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 14, 2026

Merging this PR will improve performance by 33.46%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
✅ 35 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation test_benchmarks_lanczos_interp[xval-no_conserve_dc-run] 1,105.5 µs 828.3 µs +33.46%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing equinox-errs (85569db) with main (d69a8ba)

Open in CodSpeed

@beckermr beckermr requested a review from ismael-mendoza May 14, 2026 11:56
@beckermr beckermr marked this pull request as ready for review May 14, 2026 11:56
@beckermr
Copy link
Copy Markdown
Collaborator Author

OK @ismael-mendoza! This is the first PR in a series that adds runtime init checks to the various classes. I don't think I'll request review for all of them, but I wanted to get eyes on the first one so we all understand the syntax and implications. Please take a look!

@beckermr beckermr marked this pull request as draft May 14, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant