fix: raise errors for invalid shears and PixelScale WCS inits#242
Draft
beckermr wants to merge 6 commits into
Draft
fix: raise errors for invalid shears and PixelScale WCS inits#242beckermr wants to merge 6 commits into
beckermr wants to merge 6 commits into
Conversation
Merging this PR will improve performance by 33.46%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | test_benchmarks_lanczos_interp[xval-no_conserve_dc-run] |
1,105.5 µs | 828.3 µs | +33.46% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing equinox-errs (85569db) with main (d69a8ba)
Collaborator
Author
|
OK @ismael-mendoza! This is the first PR in a series that adds runtime init checks to the various classes. I don't think I'll request review for all of them, but I wanted to get eyes on the first one so we all understand the syntax and implications. Please take a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds runtime init error checking to the Shear class. It uses the
equinox.error_iffunction. The net result is that the code now raises for invalid shears. Unfortunately there is no way to raise exceptions besides theequinox.EquinoxRuntimeErrorand according to the equinox issue tracker, enabling custom exceptions is not a feature they plan to support. We can't use subclassing IIUIC because the inheritance goes the wrong way.xref: #237