fix(reth): improve error handling in coordinator tasks and block id lookup#643
Merged
fix(reth): improve error handling in coordinator tasks and block id lookup#643
Conversation
ByteYue
force-pushed
the
docs/audit-review-with-authors
branch
from
4a18e53 to
131bd83
Compare
Lchangliang
previously approved these changes
Apr 7, 2026
ByteYue
force-pushed
the
docs/audit-review-with-authors
branch
from
131bd83 to
596e07a
Compare
keanji-x
approved these changes
Apr 7, 2026
…ookup - Replace panic with error propagation in `start_commit` when block ID is not found, avoiding silent crash loops in spawned tasks (C-49) - Restructure RethCoordinator::run to monitor all spawned tasks via tokio::select and exit with error log on unexpected task failure, preventing silent deadlocks (C-48) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ByteYue
force-pushed
the
docs/audit-review-with-authors
branch
from
596e07a to
71556c0
Compare
keanji-x
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
panic!with error propagation (?) instart_commitwhen block ID is not found, avoiding silent crash loops in spawned tasks (audit issue C-49)RethCoordinator::runto monitor all spawned tasks viatokio::select!and exit with error log on unexpected task failure, preventing silent deadlocks (audit issue C-48)480656a8ea(hardfork E2E test framework and gamma test suite)Test plan
start_commitgracefully returns error instead of panicking when block ID lookup fails🤖 Generated with Claude Code