Merged
Conversation
Currently only works for none or cout printer Will allow all standalones to build regardless of build order. Does not contain an error message when the DarkBitmodule function to pull form the postprocessor is used.
This will cover any of the cases known to fail. Also removed a now out of date hack for suspicious points and the standalones.
…t_A_standalone as an example.
Collaborator
Author
|
I added a commit that allows any printer to be used in a standalone. This requires many more printer commands, so if others think that they would prefer it without these changes, I can simply revert the commit. I only did this for the ExampleBit_A_standalone to demonstrate. |
tegonzalo
requested changes
Jan 23, 2024
Collaborator
tegonzalo
left a comment
tegonzalo
left a comment
There was a problem hiding this comment.
The standalones build as expected and run as expected (except 3bithit and FlavBit cause of FeynHiggs). I asked for some file shuffiling and cosmetic changes
Collaborator
Author
|
I think I've addressed your PR comments. Please have a look and let me know if there is anything else. |
tegonzalo
approved these changes
May 28, 2024
Collaborator
tegonzalo
left a comment
tegonzalo
left a comment
There was a problem hiding this comment.
All good here too. Waiting for some tests to finish, will merge right after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the printers to the standalone builds. This should let the standalones successfully build when built one at a time, and on the Macs. Once combined with PRs #462 and #412 , this should (hopefully) allow the Mac CIs to get past all of their current issues.
Currently only the cout or none printers work. There is a check for whether those are used in the standalone util function made use of. This also removes the script that edited code depending on make targets.
Perhaps we can allow the standalones to make full use of the printers, but that will require more work.
Setting @tegonzalo as the reviewer, but feel free to change to someone else if you prefer.