-
-
Notifications
You must be signed in to change notification settings - Fork 0
URCA CAN Tooling ✨ #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
URCA CAN Tooling ✨ #176
Conversation
… save changes functionality
# Setup Perl Tidy and Action ## Problem and Scope Similar to Perl Critic, clean up the URCA Perl code ## Description Automatically formats the Perl code ## Gotchas and Limitations Includes some minor bugfixes to URCA code ## Testing - [x] HOOTL testing - [ ] HITL testing - [x] Human tested ### Testing Details Works still ## Larger Impact Easier to maintain ## Additional Context and Ticket See #173, related to #174 --------- Signed-off-by: ReginaldWang <114448545+ReginaldWang@users.noreply.github.com> Signed-off-by: Daniel Hansen <105574022+dchansen06@users.noreply.github.com> Co-authored-by: Daniel Hansen <dchansen06@gmail.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel Hansen <105574022+dchansen06@users.noreply.github.com>
dchansen06
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review done in prep for Monday to help with GitHub Actions
Many files should not have been edited but appear to have AI-style changes in them
| # CANfigurator | ||
| Autogen/CAN/Inc/can_msg_ids.h | ||
| Autogen/CAN/Inc/CANDler.h | ||
| Autogen/CAN/Inc/Custom_CAN_ID.h | ||
| Autogen/CAN/Inc/GR_IDS.h | ||
| Autogen/CAN/Inc/output.dbc | ||
| Autogen/CAN/Src/output.dbc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put all of your .gitignore modifications into Autogen/CAN/.gitignore instead
… .gitignore into Autogen/CAN
URCA Can Tooler
Problem and Scope
Last year CAN ID updating very painful and sad -- manual downloading/parsing of google sheet per change.
Description
ID Constants to autogenerate header files upon compile from custom yaml format to enums/structs/as needed.
Gotchas and Limitations
No nice UI, single raw huge yaml file. Other stuff.
Testing
Lots of it. Error handling for all incorrect input, testing with last year's data spreadsheet
Testing Details
Yes
Larger Impact
Reduce data->code conversion errors, less manual human labor & upkeep needed to manage IDs.
Additional Context and Ticket