PerlCritic for URCA #179
Draft
PerlCritic for URCA #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
Updated with rebase |
dchansen06
force-pushed
the
PerlCritic
branch
from
2b9e768 to
c142d97
Compare
dchansen06
added
Documentation
Contributor
|
Updating with rebase |
Signed-off-by: ReginaldWang <114448545+ReginaldWang@users.noreply.github.com>
Signed-off-by: ReginaldWang <114448545+ReginaldWang@users.noreply.github.com>
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: ReginaldWang <114448545+ReginaldWang@users.noreply.github.com>
dchansen06
force-pushed
the
PerlCritic
branch
from
32027bf to
48febdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Perl Critic
Problem and Scope
Trying to resolve issue #174 for CAN URCA, who are writing in Perl. A Perl::Critic implementation was desired for verifying commits.
Description
Added a minimal Perl::Critic file with an appropriate GitHub Action in a .yml file, which is named similarly.
Gotchas and Limitations
A .perlcritic file allows for a range of harshness when it comes to checking, as well as how descriptive it is in describing errors. This ranges from 1-5 and 1-11, respectively. I just chose somewhere in the middle for both, but if it is ineffective or overly annoying, I can change the numbers.
Testing
Testing Details
Larger Impact
Additional Context and Ticket