Skip to content

Conversation

@ahoysal
Copy link
Contributor

@ahoysal ahoysal commented Jan 27, 2026

CAN RX Callback with Identifiers

Problem and Scope

The current CAN RX Callback does not pass in the message ID.

Description

The RX callback typedef now passes in the message ID as an additional parameter GR_OLD_MSG_ID id.

Gotchas and Limitations

Testing

  • HOOTL testing
  • HITL testing
  • Human tested

Testing Details

Larger Impact

Additional Context and Ticket

@ahoysal ahoysal requested a review from dchansen06 as a code owner January 27, 2026 05:16
Copy link
Contributor

@dchansen06 dchansen06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide both the message ID GR_OLD_MSG_ID and the sending node ID GR_OLD_NODE_ID (both are held in the underlying identifier, see CANutils.c)

@dchansen06 dchansen06 marked this pull request as draft January 27, 2026 06:47
@dchansen06 dchansen06 added Enhancement New feature or request 2 PRIORITY Important and a priority, but less than URGENT Small Fry Something that is small, could include bug fixes or smaller changes Peripheral Related to or involving a peripheral including abstractions labels Jan 27, 2026
@dchansen06 dchansen06 marked this pull request as ready for review January 27, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 PRIORITY Important and a priority, but less than URGENT Enhancement New feature or request Peripheral Related to or involving a peripheral including abstractions Small Fry Something that is small, could include bug fixes or smaller changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants