Fix #396, display primitive doesn't need BPM or illum mask.#425
Open
MichaelRFairhurst wants to merge 1 commit intoGeminiDRSoftware:masterfrom
Open
Fix #396, display primitive doesn't need BPM or illum mask.#425MichaelRFairhurst wants to merge 1 commit intoGeminiDRSoftware:masterfrom
MichaelRFairhurst wants to merge 1 commit intoGeminiDRSoftware:masterfrom
Conversation
Contributor
|
Thanks Michael! We just noticed the PR. Our in-house Jenkins test server cannot run on the PR probably because the changes are in your fork. We don't get external PRs very often. We're looking into defining a procedure. The changes look good to me and we'll take them, once we got the Jenkins thing sorted. Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looked like #396 was an easy fix waiting to be picked up. Hoping this PR is an easy review and helpful.
Let me know if it seems better to use a mocking library; I didn't see any in use in the project and worked without it.
Also worth nothing: I did use TDD on this, that is to say, I know that this new test fails without the corresponding update to
Visualize.display. However, the test in this design could stop being effective if parameter defaults are changed/methods are renamed/etc. If there's a better approach to testing this, I would be happy to change the test accordingly. It also may not be an important regression to keep as a test, if CI speed is an issue.Cheers!