Fix Mobile Navigation Responsiveness in Admin and Dark Lab Portals#494
Open
prince-shakyaa wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Open
Fix Mobile Navigation Responsiveness in Admin and Dark Lab Portals#494prince-shakyaa wants to merge 1 commit intoGenAI-Security-Project:mainfrom
prince-shakyaa wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Conversation
57c0845 to
310698e
Compare
- Remove restrictive 'relative z-10' and 'overflow-hidden' from layout wrappers in admin/base.html and darklab/base.html - Add 'sticky top-0 h-screen' to aside elements for stable mobile layout - Update portal.css mobile media query: - Normalize z-index: sidebar (10001), overlay (10000), toggle (10002) - Scope overlay to left: 320px to prevent link interception - Force pointer-events: auto !important on open sidebar and children - Add mobile touch navigation handlers in utils.js sidebar.open() - Add inline _attachMobileSidebarNav() script to both base templates to guarantee interaction regardless of browser caching - Add missing volume mount to docker-compose.yml for real-time updates
e0903d3 to
d6f45bc
Compare
Author
|
Hi @saikishu ,I've resolved the mobile sidebar unresponsiveness by fixing a hidden overlay interception issue and neutralizing restrictive stacking contexts in the Admin/Dark Lab layouts. This aligns the portals with the working Vendor implementation-ready for your final review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description: Fix Mobile Navigation Sidebar for Admin and Dark Lab Portals
Summary
This PR resolves a critical UI/UX bug where the mobile hamburger menu sidebar in the Admin and Dark Lab portals was unresponsive to touch interactions. While the sidebar would open, the links inside (e.g., "Messages") were unclickable due to stacking context conflicts and overlay interception.
Changes Made
relative z-10andoverflow-hiddenfrom main layout wrappers inadmin/base.htmlanddarklab/base.html. This prevents the sidebar from being "trapped" in a lower layer than the background overlay.sticky top-0 h-screen, matching the working implementation in the Vendor portal.portal.css: Toggle (10002) > Sidebar (10001) > Overlay (10000).sidebar-overlaytoleft: 320pxon mobile, ensuring it physically cannot overlap the sidebar area and intercept clicks.pointer-events: auto !importantto the open sidebar and all descendant anchors to force interaction registration.touchendlistener insidebar.init()(utils.js) that forceswindow.location.hrefnavigation._attachMobileSidebarNav()script in the base templates to guarantee the fix works even if static files are cached.Rationale
The issue was multi-faceted:
overflow-hiddenandz-indexon wrappers created a "caged" stacking context.sidebar-overlaywas set toleft: 0, meaning it sat invisibly on top of the sidebar links, swallowing all click/touch events.utils.jsfrom being applied immediately.By fixing the CSS layering and adding capture-phase touch listeners, we've ensured that navigation links are always reachable and responsive on mobile devices.
Screen Recording
Attach your screen recording here showing the mobile menu opening and successfully navigating to "Messages"
Screen.Recording.2026-05-08.at.19.43.07.mov
Verification
fixes #493