Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fhennig
force-pushed
the
fix-wastewater-undefined-values
branch
from
458349d to
e0add9c
Compare
fhennig
force-pushed
the
fix-wastewater-undefined-values
branch
from
e0add9c to
f6279f5
Compare
fhennig
force-pushed
the
fix-wastewater-undefined-values
branch
from
f6279f5 to
87cffd8
Compare
chaoran-chen
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a bug we currently have on prod GenSpectrum.
Summary
The Tooltip expects the value to be
nullor aProportionValue.The code that fetches the wastewater data doesn't use null for missing values, but instead uses undefined. This PR changes that so it's in line with the mutations-over-time fetching code.
I've also added a defensive check that issues a console warning if there is an undefined value again. But this is not triggered at the moment - Because of the interface used, the type allows
undefinedat that point, so we have to deal with potential undefined values somehow. I think a console log is appropriate.Screenshot
PR Checklist