feat: adapt output format to be compatible with SILO 0.8.0#11
Merged
chaoran-chen merged 2 commits intomainfrom Sep 2, 2025
Merged
feat: adapt output format to be compatible with SILO 0.8.0#11chaoran-chen merged 2 commits intomainfrom
chaoran-chen merged 2 commits intomainfrom
Conversation
Taepper
reviewed
Sep 2, 2025
Contributor
Taepper
left a comment
Taepper
left a comment
There was a problem hiding this comment.
LGTM. I would merge this first, and then update the fixed SILO version to the new commit id on main
Taepper
approved these changes
Sep 2, 2025
Contributor
|
I can confirm that this is worked multiple times on staging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10
This makes the necessary changes to the output so that it is compatible with the changes introduced in GenSpectrum/LAPIS-SILO#879.