Open
Conversation
Dao-Ho
requested changes
Feb 14, 2026
| { label: 'Floor 3', value: 3 }, | ||
| ] | ||
| } | ||
| ]; |
Contributor
There was a problem hiding this comment.
since this is temporary, I'd be make a global const for the file rather than embedding it in the function itself.
const FILTER_CONFIG
| return ( | ||
| <Pressable | ||
| onPress={onPress} | ||
| className={`flex-row items-center p-[3vw] border border-gray-300 rounded-md active:bg-gray-100 ${className || ''}`} |
Contributor
There was a problem hiding this comment.
we shouldn't need || '' to default every time we have an optional className parameter
I would implement a utils cn function for you to merge classNames (would be very useful for future class merges/fusion as well
import { clsx, type ClassValue } from "clsx";
import { twMerge } from "tailwind-merge";
export function cn(...inputs: ClassValue[]) {
return twMerge(clsx(inputs));
}
call ex.
className={cn(
'flex-row items-center p-[3vw] border border-gray-300 rounded-md active:bg-gray-100',
className
)}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issue(s)
Related to #103
What Changed?
expo should expose it
Testing & Validation
How this was tested
Tested visually with the frontend
Screenshots/Recordings
demo
Unfinished Work & Known Issues
Pre-Merge Checklist
Code Quality
Testing & CI
Documentation
Reviewer Notes