Skip to content

feat: add rooms lofi page for web#137

Merged
eric-kitagawa merged 10 commits intomainfrom
eric/rooms-page
Feb 19, 2026
Merged

feat: add rooms lofi page for web#137
eric-kitagawa merged 10 commits intomainfrom
eric/rooms-page

Conversation

@eric-kitagawa
Copy link
Copy Markdown
Contributor

@eric-kitagawa eric-kitagawa commented Feb 18, 2026 •
edited
Loading

Description

Adds lofi for rooms page on web

  • Basic filtering of rooms
  • Drawer for selecting individual rooms

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (code improvement without changing functionality)
  • Documentation update
  • Configuration/infrastructure change
  • Performance improvement
  • Test coverage improvement

Related Issue(s)

Closes #102
Related to #102

Screenshots/Recordings

Screenshot 2026-02-19 at 1 17 57 AM
rooms-lofi.mov
rooms-lofi-2.mov

Unfinished Work & Known Issues

  • None, this PR is complete and production-ready
  • [X ] The following items are intentionally deferred:
    • The filtering logic all works but it's tightly coupled to the rooms page. Want to make this generic
    • The drawer room select will render a new drawer per room, but all the content is hardcoded
    • Smarter decisions for the components can be made, lots of repeat code, have to think harder about what i can make generic and what is specific to this page (Figured I just get something out for all-hands. Will work on this more in a separate pr before backend ticket / during hifis)

@eric-kitagawa eric-kitagawa changed the title Eric/rooms page feat: add rooms lofi page Feb 19, 2026
@eric-kitagawa eric-kitagawa changed the title feat: add rooms lofi page feat: add rooms lofi page for web Feb 19, 2026
@eric-kitagawa eric-kitagawa marked this pull request as ready for review February 19, 2026 06:20
Dao-Ho
Dao-Ho requested changes Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some smol comments, otherwise a great ship!!! LFGolang! 🔥

Comment thread clients/web/src/components/rooms/FloorFilterDropdown.tsx Outdated
Comment thread clients/web/src/components/rooms/OverviewCard.tsx Outdated
Comment thread clients/web/src/components/rooms/RoomCard.tsx Outdated
Comment thread clients/web/src/components/rooms/RoomsOverview.tsx
Comment thread clients/web/src/mock-data/rooms.ts
Comment thread clients/web/src/routes/_protected/rooms.index.tsx Outdated
Comment thread clients/web/src/routes/_protected/rooms.index.tsx Outdated
Comment thread clients/web/src/routes/rooms.tsx Outdated
@eric-kitagawa eric-kitagawa self-assigned this Feb 19, 2026
@eric-kitagawa eric-kitagawa requested a review from Dao-Ho February 19, 2026 17:31
Dao-Ho
Dao-Ho approved these changes Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Dao-Ho Dao-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LET'S GOOO 🔥 LGTM 🚢 🚢 🚢

@eric-kitagawa eric-kitagawa merged commit a35f3d6 into main Feb 19, 2026
8 checks passed
@eric-kitagawa eric-kitagawa deleted the eric/rooms-page branch February 19, 2026 17:38
manueltorres0 pushed a commit that referenced this pull request Feb 19, 2026
@eric-kitagawa @manueltorres0
feat: add rooms lofi page for web (#137)
bd0341f 
* feat: basic overlay of rooms page

* feat: add working filtering to rooms page
manueltorres0 added a commit that referenced this pull request Feb 19, 2026
@manueltorres0 @Dao-Ho @eric-kitagawa
Feat/guest profile page (#117)
73f3474 
* guests list done

* comments in some areas

* guest profile completed

* fixed routing and grouping

* feat: add rooms lofi page for web (#137)

* feat: basic overlay of rooms page

* feat: add working filtering to rooms page

* fixed mcs

---------

Co-authored-by: Dao Ho <84757503+Dao-Ho@users.noreply.github.com>
Co-authored-by: Eric Kitagawa <160809324+eric-kitagawa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dao-Ho Dao-Ho Dao-Ho approved these changes

@danctila danctila Awaiting requested review from danctila

Assignees

@eric-kitagawa eric-kitagawa

Labels

changes requested needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: lofi for rooms page web

2 participants

@eric-kitagawa @Dao-Ho