Conversation
…ttom sheet and keyboard positioning
…rop in BottomSheet
…rity (#2884) * add behavior computation module with tests, implement in ContentOverlay * clean up tests * update spelling for consistency * update logic to mirror existing * revert back to position for top logic
jdeichert
reviewed
Jan 23, 2026
| {renderHeader()} | ||
| <View testID="ATL-Overlay-Children">{children}</View> | ||
| </BottomSheetScrollView> | ||
| <BottomSheetView style={{ height: windowHeight }}> |
Contributor
There was a problem hiding this comment.
I'm hoping so! it seems to have fixed it for me, fingers crossed that holds true.
I found this solution and one other one where someone was saying that a lack of a fixed height dimension on the parent was the issue. their fix was to apply a height to the entire app, but I was curious if you could do it for the scrollview parent instead.
…oller (#2889) * add RNKC, use to fix SV issues in ContentOverlay * prevent ts errors in mocks * provide override for RNKC package * add additional mocks for site * add aliases for RN packages to avoid vite failures * revert aliases, use exernal instead * surgically correct package-lock state * update package-lock dep locations
jdeichert
approved these changes
Feb 2, 2026
…t-it-in-content-overlay
…t-it-in-content-overlay
…om:GetJobber/atlantis into JOB-140606-implement-it-in-content-overlay
edison-cy-yang
commented
Mar 18, 2026
Comment on lines
+323
to
+333
| const isKeyboardHandledByScrollView = useIsKeyboardHandledByScrollView(); | ||
| const bottomSheetContext = useBottomSheetInternal(true); | ||
| const shouldHandleBottomSheetKeyboard = | ||
| bottomSheetContext !== null && !isKeyboardHandledByScrollView; | ||
| const animatedKeyboardState = shouldHandleBottomSheetKeyboard | ||
| ? bottomSheetContext.animatedKeyboardState | ||
| : undefined; | ||
| const textInputNodesRef = shouldHandleBottomSheetKeyboard | ||
| ? bottomSheetContext.textInputNodesRef | ||
| : undefined; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This resolves the issue we saw where there is a big gap in the scroll view when input text is focused and keyboard appears.
- If scrollEnabled and using KeyboardAwareScrollView -> set animatedKeyboardState and textInputNodesRef in bottomSheetContext to undefined, so handleBottomSheetFocus and handleBottomSheetBlur will early return
- if scrollEnabled is false and not using KeyboardAwareScrollView -> read actual bottom sheet context and let the handlers do their thing to achieve keyboard aware scroll
Contributor
|
a couple small updates we need to make
I think that's all, but worth double checking I haven't missed something in the other BottomSheet PR that has merged already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remaining tasks
keyboardAvoidingBehaviorprop not implementedavoidKeyboardLikeIOSprop not implementedmodalForLargeScreensstyle not appliedBottomSheetModalandBottomSheetScrollViewinMockBottomSheetContentOverlay, there should be no rebuilt.We also need to go through existing ContentOverlay usages and find out what kind of inputs are currently being used. I realized
BottomSheet.InputTextmay not be the only wrapper input component we need. To recap,BottomSheet.InputTextis a wrapper aroundInputTextthat implementsonFocusandonBlurto properly position keyboard against these inputs. If we do indeed need more wrapper inputs, we will need to follow the pattern inBottomSheet.InputTextfor every input component, and replace each existing instance 🥲This PR targets #2803, but does not depend on it.
Motivations
Changes
Added
Changed
Deprecated
Removed
Fixed
Security
Testing
ContentOverlay.rebuilt.tsxis created for the sake of testing the old version and compare against the new one in simulator. This should not be a rebuilt and should completely replaceContentOverlay.tsxTo test with live linking:
meta.jsonChanges can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.