Fix Fake-TLS ClientHello detection to support TLS 1.2/1.3#25
Merged
dvershinin merged 2 commits intomasterfrom Dec 28, 2025
Merged
Fix Fake-TLS ClientHello detection to support TLS 1.2/1.3#25dvershinin merged 2 commits intomasterfrom
dvershinin merged 2 commits intomasterfrom
Conversation
Co-authored-by: dvershinin <250071+dvershinin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Fake-TLS mode handling for Telegram connections
Fix Fake-TLS ClientHello detection to support TLS 1.2/1.3
Dec 28, 2025
Copilot AI
added a commit
that referenced
this pull request
Dec 28, 2025
This fix reverts the problematic changes from PR #24 and PR #25 that broke Fake-TLS connections: 1. Revert TLS ClientHello detection to original pattern: The change in PR #25 incorrectly checked the length byte instead of TLS version, which could cause detection failures. 2. Remove the tag validation check that was incorrectly rejecting EE/EF modes: - For Fake-TLS connections (C_IS_TLS set), any valid tag should be accepted - For non-TLS connections with allow_only_tls=1, connection is rejected earlier - This check was unnecessary and was causing EE mode to fail Fixes #23 Co-authored-by: dvershinin <250071+dvershinin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fake-TLS connections fail when using the
-Ddomain option because the TLS ClientHello detection only matches TLS 1.0. Modern Telegram clients use TLS 1.2/1.3, causing connections to be incorrectly proxied to the fallback domain instead of being handled as MTProxy traffic.Changes
TLS version detection (line 1115)
Debug logging
Technical Details
TLS ClientHello record header structure:
0x16(Handshake record type)0x0301= TLS 1.0,0x0303= TLS 1.2/1.3)When read as little-endian uint32:
0x??0103160x??030316The fixed condition checks bytes 0-1 only, accepting any TLS minor version.
Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.