Open
Conversation
Нахуй он здесь не нужен
Endevir
reviewed
Mar 11, 2018
| }; | ||
|
|
||
| Cell::Cell(Unit & character) { | ||
| leftUp_ = left_ = leftDown_ = nullptr; |
Member
There was a problem hiding this comment.
Переменные называем вот так: left_up_
Endevir
reviewed
Mar 11, 2018
Cell.cpp
Outdated
| bool СanAttack(int) { return true; } | ||
| }; | ||
|
|
||
| Cell::Cell(Unit & character) { |
Member
There was a problem hiding this comment.
- В качестве аргумента лучше передавать указатель на character.
- А если надо создать пустую клетку?
Endevir
requested changes
Mar 11, 2018
Member
Endevir
left a comment
Endevir
left a comment
There was a problem hiding this comment.
Ну исправить по комментам, короче 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Все продебажил. Возможно даже работает