Conversation
inauros
suggested changes
Aug 26, 2019
inauros
left a comment
There was a problem hiding this comment.
Please update your SRS as follows:
- In accordance with Step 5, SRS should be created under the folder "documentation" created in the root of the repository.
- Filtering by date of birth for employees is missing. Please add it to the list "Application should provide:"
- I think it makes sense to rename the following buttons:
- Department -> Departments
- Employee -> Employees
- Scenario 1.2 Add employee, step User enters employee data and presses “✓” button - the “✓” button should be added to the screenshot
- Scenario 1.4 Edit Employee, step User clicks on the “✓” button: the “✓” button should be added to the screenshot
- Scenarios should be described in more detail (for example, what should happen if the user entered incorrect data or did not enter the data in the required fields? How should the system behave if the user tries to remove the department in which there are employees?).
- The Departments page: in accordance with the requirements, on this page you should display a list of departments and the average salary (calculated automatically) for these departments (See step 12 or my e-mail with instructions).
- Scenario 2.2 Add department, step User enters department data and presses “✓” button - the “✓” button should be added to the screenshot
- Scenario 2.4 Edit department is missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.